Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/ --- (Updated 十月 23, 2015, 9:05 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-23 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103745 --- Ship it! LGTM ! - Anand Mazumdar On Oct. 23, 2015, 9:05 a.m.,

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103752 --- Patch looks great! Reviews applied: [39548] All tests passed. -

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-23 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103810 --- Ship it! Ship It! - Vinod Kone On Oct. 23, 2015, 9:05 a.m.,

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103735 --- Patch looks great! Reviews applied: [39548] All tests passed. -

Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3733

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103660 --- src/tests/scheduler_tests.cpp (line 1001)

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103710 --- src/tests/scheduler_tests.cpp (lines 999 - 1008)

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/ --- (Updated Oct. 23, 2015, 2:32 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/#review103711 --- Patch looks great! Reviews applied: [39548] All tests passed. -

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-22 Thread Guangya Liu
> On 十月 23, 2015, 3:53 a.m., Anand Mazumdar wrote: > > src/tests/scheduler_tests.cpp, lines 999-1008 > > > > > > Wondering, why did you change order here i.e. move this piece of code > > up ? > > > > Now,

Re: Review Request 39548: SchedulerTest.Suppress is flaky

2015-10-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39548/ --- (Updated 十月 23, 2015, 5:29 a.m.) Review request for mesos and Vinod Kone.