Re: Review Request 39628: Clear the suppressed flag when deactive a framework
> On Oct. 25, 2015, 2:51 p.m., Ben Mahler wrote: > > Can you please add a test that would have caught this issue? > > Guangya Liu wrote: > I think this is a bug, I tested without my code change, the test also > failed sometimes. Shall we file a bug for this? > > Vinod Kone wrote: > the failed test looks unrelated. please do file a bug. also, please write > a test for this change. > > Guangya Liu wrote: > JIRA ticket for this https://issues.apache.org/jira/browse/MESOS-3813 > > Guangya Liu wrote: > Vinod, I found that the unit test can not cover this part as the test > framework cannot get the variable values in hierarchical.cpp. > > What I want to test is make sure the value of > frameworks[frameworkId].suppressed is false, but the problem is that the test > framework cannot get this value. Comments? > > Guangya Liu wrote: > Vinod, any comments on this? Thanks! But you can test that a re-activated framework gets offers right? in other words, restart the framework after it calls suppress and make sure it gets offers. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/#review103957 --- On Oct. 30, 2015, 6:52 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39628/ > --- > > (Updated Oct. 30, 2015, 6:52 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3802 > https://issues.apache.org/jira/browse/MESOS-3802 > > > Repository: mesos > > > Description > --- > > Clear the suppressed flag when deactive a framework > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39628/diff/ > > > Testing > --- > > Ubuntu 14.04 > make > make check > > > Thanks, > > Guangya Liu > >
Re: Review Request 39628: Clear the suppressed flag when deactive a framework
> On 十月 25, 2015, 2:51 p.m., Ben Mahler wrote: > > Can you please add a test that would have caught this issue? > > Guangya Liu wrote: > I think this is a bug, I tested without my code change, the test also > failed sometimes. Shall we file a bug for this? > > Vinod Kone wrote: > the failed test looks unrelated. please do file a bug. also, please write > a test for this change. > > Guangya Liu wrote: > JIRA ticket for this https://issues.apache.org/jira/browse/MESOS-3813 > > Guangya Liu wrote: > Vinod, I found that the unit test can not cover this part as the test > framework cannot get the variable values in hierarchical.cpp. > > What I want to test is make sure the value of > frameworks[frameworkId].suppressed is false, but the problem is that the test > framework cannot get this value. Comments? Vinod, any comments on this? Thanks! - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/#review103957 --- On 十月 30, 2015, 6:52 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39628/ > --- > > (Updated 十月 30, 2015, 6:52 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3802 > https://issues.apache.org/jira/browse/MESOS-3802 > > > Repository: mesos > > > Description > --- > > Clear the suppressed flag when deactive a framework > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39628/diff/ > > > Testing > --- > > Ubuntu 14.04 > make > make check > > > Thanks, > > Guangya Liu > >
Re: Review Request 39628: Clear the suppressed flag when deactive a framework
> On Oct. 25, 2015, 2:51 p.m., Ben Mahler wrote: > > Can you please add a test that would have caught this issue? > > Guangya Liu wrote: > I think this is a bug, I tested without my code change, the test also > failed sometimes. Shall we file a bug for this? > > Vinod Kone wrote: > the failed test looks unrelated. please do file a bug. also, please write > a test for this change. > > Guangya Liu wrote: > JIRA ticket for this https://issues.apache.org/jira/browse/MESOS-3813 Vinod, I found that the unit test can not cover this part as the test framework cannot get the variable values in hierarchical.cpp. What I want to test is make sure the value of frameworks[frameworkId].suppressed is false, but the problem is that the test framework cannot get this value. Comments? - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/#review103957 --- On Oct. 25, 2015, 2:38 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39628/ > --- > > (Updated Oct. 25, 2015, 2:38 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3802 > https://issues.apache.org/jira/browse/MESOS-3802 > > > Repository: mesos > > > Description > --- > > Clear the suppressed flag when deactive a framework > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39628/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
Re: Review Request 39628: Clear the suppressed flag when deactive a framework
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/ --- (Updated Oct. 30, 2015, 6:52 a.m.) Review request for mesos and Vinod Kone. Changes --- Rebase Bugs: MESOS-3802 https://issues.apache.org/jira/browse/MESOS-3802 Repository: mesos Description --- Clear the suppressed flag when deactive a framework Diffs (updated) - src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 Diff: https://reviews.apache.org/r/39628/diff/ Testing (updated) --- Ubuntu 14.04 make make check Thanks, Guangya Liu
Re: Review Request 39628: Clear the suppressed flag when deactive a framework
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/#review104544 --- Patch looks great! Reviews applied: [39628] All tests passed. - Mesos ReviewBot On Oct. 30, 2015, 6:52 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39628/ > --- > > (Updated Oct. 30, 2015, 6:52 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3802 > https://issues.apache.org/jira/browse/MESOS-3802 > > > Repository: mesos > > > Description > --- > > Clear the suppressed flag when deactive a framework > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39628/diff/ > > > Testing > --- > > Ubuntu 14.04 > make > make check > > > Thanks, > > Guangya Liu > >
Re: Review Request 39628: Clear the suppressed flag when deactive a framework
> On 十月 25, 2015, 2:51 p.m., Ben Mahler wrote: > > Can you please add a test that would have caught this issue? > > Guangya Liu wrote: > I think this is a bug, I tested without my code change, the test also > failed sometimes. Shall we file a bug for this? > > Vinod Kone wrote: > the failed test looks unrelated. please do file a bug. also, please write > a test for this change. JIRA ticket for this https://issues.apache.org/jira/browse/MESOS-3813 - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/#review103957 --- On 十月 25, 2015, 2:38 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39628/ > --- > > (Updated 十月 25, 2015, 2:38 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3802 > https://issues.apache.org/jira/browse/MESOS-3802 > > > Repository: mesos > > > Description > --- > > Clear the suppressed flag when deactive a framework > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39628/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
Re: Review Request 39628: Clear the suppressed flag when deactive a framework
> On Oct. 25, 2015, 2:51 p.m., Ben Mahler wrote: > > Can you please add a test that would have caught this issue? > > Guangya Liu wrote: > I think this is a bug, I tested without my code change, the test also > failed sometimes. Shall we file a bug for this? the failed test looks unrelated. please do file a bug. also, please write a test for this change. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/#review103957 --- On Oct. 25, 2015, 2:38 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39628/ > --- > > (Updated Oct. 25, 2015, 2:38 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3802 > https://issues.apache.org/jira/browse/MESOS-3802 > > > Repository: mesos > > > Description > --- > > Clear the suppressed flag when deactive a framework > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39628/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
Re: Review Request 39628: Clear the suppressed flag when deactive a framework
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/#review103957 --- Can you please add a test that would have caught this issue? - Ben Mahler On Oct. 25, 2015, 2:38 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39628/ > --- > > (Updated Oct. 25, 2015, 2:38 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3802 > https://issues.apache.org/jira/browse/MESOS-3802 > > > Repository: mesos > > > Description > --- > > Clear the suppressed flag when deactive a framework > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39628/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
Re: Review Request 39628: Clear the suppressed flag when deactive a framework
> On 十月 25, 2015, 2:51 p.m., Ben Mahler wrote: > > Can you please add a test that would have caught this issue? I think this is a bug, I tested without my code change, the test also failed sometimes. Shall we file a bug for this? - Guangya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/#review103957 --- On 十月 25, 2015, 2:38 a.m., Guangya Liu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39628/ > --- > > (Updated 十月 25, 2015, 2:38 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-3802 > https://issues.apache.org/jira/browse/MESOS-3802 > > > Repository: mesos > > > Description > --- > > Clear the suppressed flag when deactive a framework > > > Diffs > - > > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39628/diff/ > > > Testing > --- > > > Thanks, > > Guangya Liu > >
Review Request 39628: Clear the suppressed flag when deactive a framework
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3802 https://issues.apache.org/jira/browse/MESOS-3802 Repository: mesos Description --- Clear the suppressed flag when deactive a framework Diffs - src/master/allocator/mesos/hierarchical.cpp f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 Diff: https://reviews.apache.org/r/39628/diff/ Testing --- Thanks, Guangya Liu
