Re: Review Request 39628: Cleared the suppressed flag when deactive a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/#review114726 --- Ship it! When committing, I will s/framework1/framework/ and

Re: Review Request 39628: Cleared the suppressed flag when deactive a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/ --- (Updated 一月 14, 2016, 9:53 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39628: Cleared the suppressed flag when deactive a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/#review114471 --- Patch looks great! Reviews applied: [39628] Passed command:

Re: Review Request 39628: Cleared the suppressed flag when deactive a framework.

> On 一月 14, 2016, 10:55 p.m., Vinod Kone wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1914 > > > > > > I'm not sure why you needed to have framework2 and slave2 in this test > > at all? > > > >

Re: Review Request 39628: Cleared the suppressed flag when deactive a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/ --- (Updated 一月 15, 2016, 6:36 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39628: Cleared the suppressed flag when deactive a framework.

> On 一月 14, 2016, 10:55 p.m., Vinod Kone wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 1843-1844 > > > > > > How about > > > > // This test checks that if a framework suppresses offers,

Re: Review Request 39628: Cleared the suppressed flag when deactive a framework.

> On Jan. 14, 2016, 10:55 p.m., Vinod Kone wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 1914 > > > > > > I'm not sure why you needed to have framework2 and slave2 in this test > > at all? > > >

Re: Review Request 39628: Cleared the suppressed flag when deactive a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/#review114596 --- src/master/allocator/mesos/hierarchical.cpp (line 366)

Re: Review Request 39628: Cleared the suppressed flag when deactive a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/ --- (Updated 一月 15, 2016, 7:16 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 39628: Cleared the suppressed flag when deactive a framework.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39628/ --- (Updated 一月 15, 2016, 7:14 a.m.) Review request for mesos, Ben Mahler and