Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-11-30 Thread Ian Downes 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/#review108377
---

Ship it!


Very minor things. I'll just make the changes when I commit the patch. Thanks!


configure.ac (line 619)


End with fullstop.



src/Makefile.am (line 1756)


Can you add a comment that FreeBSD includes the  necessary functionality in 
libc?



src/tests/attributes_tests.cpp (line 38)


These are unrelated to the FreeBSD support so can you split them out? Else, 
I'll do it when I commit this patch.


- Ian Downes


On Nov. 27, 2015, 8:26 p.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39634/
> ---
> 
> (Updated Nov. 27, 2015, 8:26 p.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-1563
> https://issues.apache.org/jira/browse/MESOS-1563
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> FreeBSD: Enable mesos build and start fixing some tests
> 
> 
> Diffs
> -
> 
>   configure.ac b30a8d30076f3068fd7d5fc8ccea1982639e998a 
>   src/Makefile.am fd38cfa73d81a98c819378f99a766e2ddb7e1a04 
>   src/tests/attributes_tests.cpp d8c84d25a37f9cf1b38a97193d5b3b3001fd54ff 
>   src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12 
>   src/tests/values_tests.cpp fb7f982a50df8274ad29dab9e55157c39acdc104 
> 
> Diff: https://reviews.apache.org/r/39634/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-11-27 Thread David Forsythe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/
---

(Updated Nov. 28, 2015, 4:26 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
---

FreeBSD: Enable mesos build and start fixing some tests


Diffs (updated)
-

  configure.ac b30a8d30076f3068fd7d5fc8ccea1982639e998a 
  src/Makefile.am fd38cfa73d81a98c819378f99a766e2ddb7e1a04 
  src/tests/attributes_tests.cpp d8c84d25a37f9cf1b38a97193d5b3b3001fd54ff 
  src/tests/resources_tests.cpp dbd39cd5a6786682a7b528b6fea37ab78904cf12 
  src/tests/values_tests.cpp fb7f982a50df8274ad29dab9e55157c39acdc104 

Diff: https://reviews.apache.org/r/39634/diff/


Testing
---

make check on ubuntu 14.04


Thanks,

David Forsythe

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-11-14 Thread David Forsythe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/
---

(Updated Nov. 14, 2015, 9:02 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
---

FreeBSD: Enable mesos build and start fixing some tests


Diffs (updated)
-

  configure.ac 8b28ac78eeb3e3b5905b411b4bc0db3ccf0f543f 
  src/Makefile.am 92d07c3da897c7664c63e2af91d45921d66f64aa 
  src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 
  src/tests/resources_tests.cpp 0d084fd97ec108d5ec2d050eddc2e80ea81ffac0 
  src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 

Diff: https://reviews.apache.org/r/39634/diff/


Testing
---

make check on ubuntu 14.04


Thanks,

David Forsythe

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-11-10 Thread David Forsythe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/
---

(Updated Nov. 10, 2015, 8:33 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
---

FreeBSD: Enable mesos build and start fixing some tests


Diffs (updated)
-

  configure.ac 8b28ac78eeb3e3b5905b411b4bc0db3ccf0f543f 
  src/CMakeLists.txt c235209743de6e84deb44df31c61948f4dc8b8eb 
  src/Makefile.am ae2740a5b56351d9fd82ae3bd5c733d10a90bf2f 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 
103fe4b435e115857e2ebb071b6d88e2776736b5 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
9b2b8126f39d2b4014cfb637202670e6a06cdf56 
  src/slave/containerizer/mesos/provisioner/docker/puller.hpp 
e4202550af4deb0d355ca9ae6d71b40623f9 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
70501f1811fde5b636e5dcf751ef9356b8c7caef 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 
3fd84e380f9393a6d46544fb7fc7d24bcb6256ac 
  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
f6ae9e8919fbd010c16918ddc78aa126b9da0062 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 
2445c8132ee4af07482422f8563b408459c676b2 
  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
e883b402c32df4d7ed5edb906231500615a00da5 
  src/slave/containerizer/mesos/provisioner/docker/store.cpp 
6fdb85b3d55339556b0982598d2e5258f6159466 
  src/slave/flags.hpp 6ae7c94d2e05d81c8b970e7dcaa82d8aa4de7936 
  src/slave/flags.cpp 4bc68429679a4605056aeb120e9deee51af2dde6 
  src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 
  src/tests/containerizer/provisioner_docker_tests.cpp 
9227666868801335003aeb0fa21e6b8f0e94f2cb 
  src/tests/resources_tests.cpp e663f5ec8ed2723ae93f85a1fc3335b4a8cbe9ed 
  src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 

Diff: https://reviews.apache.org/r/39634/diff/


Testing
---

make check on ubuntu 14.04


Thanks,

David Forsythe

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-11-09 Thread David Forsythe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/
---

(Updated Nov. 10, 2015, 6:35 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
---

FreeBSD: Enable mesos build and start fixing some tests


Diffs (updated)
-

  configure.ac 8b28ac78eeb3e3b5905b411b4bc0db3ccf0f543f 
  src/Makefile.am 6ec0488027d6cfccc63ac3a6a8b0c3d8eb6c3330 
  src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 
  src/tests/resources_tests.cpp e663f5ec8ed2723ae93f85a1fc3335b4a8cbe9ed 
  src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 

Diff: https://reviews.apache.org/r/39634/diff/


Testing
---

make check on ubuntu 14.04


Thanks,

David Forsythe

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-11-03 Thread Alex Clemmer 


> On Nov. 2, 2015, 6:58 p.m., Alex Clemmer wrote:
> > configure.ac, lines 612-621
> > 
> >
> > If it's not too much trouble, it would be great to see this logic added 
> > also the `cmake/CompilationCOnfigure.cmake`. It should only be a couple 
> > lines of code.
> 
> David Forsythe wrote:
> Mind if that happens after/if this change lands? I'm not sure what the 
> ettiquite is for filing tickets on unsupported platforms, but I have no 
> problem bringing the cmake stuff up to date if this gets merged.

Sure, that sounds good, but could I ask you file a JIRA ticket so we can track 
the work? The CMake epic is here: 
https://issues.apache.org/jira/browse/MESOS-898


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/#review104756
---


On Oct. 30, 2015, 5:05 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39634/
> ---
> 
> (Updated Oct. 30, 2015, 5:05 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-1563
> https://issues.apache.org/jira/browse/MESOS-1563
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> FreeBSD: Enable mesos build and start fixing some tests
> 
> 
> Diffs
> -
> 
>   configure.ac 656766430e2720c6a407e282521102b54547fd2d 
>   src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
>   src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 
>   src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
>   src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 
> 
> Diff: https://reviews.apache.org/r/39634/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-11-02 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/#review104756
---



configure.ac (lines 612 - 621)


If it's not too much trouble, it would be great to see this logic added 
also the `cmake/CompilationCOnfigure.cmake`. It should only be a couple lines 
of code.


- Alex Clemmer


On Oct. 30, 2015, 5:05 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39634/
> ---
> 
> (Updated Oct. 30, 2015, 5:05 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-1563
> https://issues.apache.org/jira/browse/MESOS-1563
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> FreeBSD: Enable mesos build and start fixing some tests
> 
> 
> Diffs
> -
> 
>   configure.ac 656766430e2720c6a407e282521102b54547fd2d 
>   src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
>   src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 
>   src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
>   src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 
> 
> Diff: https://reviews.apache.org/r/39634/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-11-02 Thread David Forsythe 


> On Nov. 2, 2015, 6:58 p.m., Alex Clemmer wrote:
> > configure.ac, lines 612-621
> > 
> >
> > If it's not too much trouble, it would be great to see this logic added 
> > also the `cmake/CompilationCOnfigure.cmake`. It should only be a couple 
> > lines of code.

Mind if that happens after/if this change lands? I'm not sure what the 
ettiquite is for filing tickets on unsupported platforms, but I have no problem 
bringing the cmake stuff up to date if this gets merged.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/#review104756
---


On Oct. 30, 2015, 5:05 a.m., David Forsythe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39634/
> ---
> 
> (Updated Oct. 30, 2015, 5:05 a.m.)
> 
> 
> Review request for mesos and Ian Downes.
> 
> 
> Bugs: MESOS-1563
> https://issues.apache.org/jira/browse/MESOS-1563
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> FreeBSD: Enable mesos build and start fixing some tests
> 
> 
> Diffs
> -
> 
>   configure.ac 656766430e2720c6a407e282521102b54547fd2d 
>   src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
>   src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 
>   src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
>   src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 
> 
> Diff: https://reviews.apache.org/r/39634/diff/
> 
> 
> Testing
> ---
> 
> make check on ubuntu 14.04
> 
> 
> Thanks,
> 
> David Forsythe
> 
>

Re: Review Request 39634: FreeBSD: Enable mesos build and start fixing some tests

2015-10-29 Thread David Forsythe 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39634/
---

(Updated Oct. 30, 2015, 5:05 a.m.)


Review request for mesos and Ian Downes.


Bugs: MESOS-1563
https://issues.apache.org/jira/browse/MESOS-1563


Repository: mesos


Description
---

FreeBSD: Enable mesos build and start fixing some tests


Diffs (updated)
-

  configure.ac 656766430e2720c6a407e282521102b54547fd2d 
  src/Makefile.am d6eb302f0e812a777f51f421deef89140871a1db 
  src/tests/attributes_tests.cpp 4fc0c31c3b2eb745432818c99746a097fde65df3 
  src/tests/resources_tests.cpp 6584fc6c39e6ffe9f8085576677dcc669f127697 
  src/tests/values_tests.cpp e9b1079bbadf05390b39bedd5ad5677f3d4ec0d8 

Diff: https://reviews.apache.org/r/39634/diff/


Testing
---

make check on ubuntu 14.04


Thanks,

David Forsythe