Re: Review Request 39792: Updated master and slave to properly set task status uuid.

2015-11-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39792/ --- (Updated Nov. 5, 2015, 3:38 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 39792: Updated master and slave to properly set task status uuid.

2015-11-05 Thread Vinod Kone
> On Nov. 5, 2015, 1:41 a.m., Ben Mahler wrote: > > src/master/master.cpp, lines 4410-4418 > > > > > > Would be great to continue wrapping comment paragraphs at 70 even > > though it's not a hard rule, for

Re: Review Request 39792: Updated master and slave to properly set task status uuid.

2015-11-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39792/#review105200 --- Ship it! src/master/master.cpp (lines 4410 - 4418)

Re: Review Request 39792: Updated master and slave to properly set task status uuid.

2015-11-02 Thread Vinod Kone
> On Oct. 30, 2015, 9:43 p.m., Ben Mahler wrote: > > Hm.. we're still relying on the update uuid, shouldn't we be trying to move > > off of it onto the status uuid? As mentioned in the comments, we can't yet remove uuid because of old checkpointed updates :( > On Oct. 30, 2015, 9:43 p.m.,

Re: Review Request 39792: Updated master and slave to properly set task status uuid.

2015-11-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39792/ --- (Updated Nov. 2, 2015, 7:32 p.m.) Review request for mesos, Anand Mazumdar and

Re: Review Request 39792: Updated master and slave to properly set task status uuid.

2015-10-30 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39792/#review104622 --- Hm.. we're still relying on the update uuid, shouldn't we be

Review Request 39792: Updated master and slave to properly set task status uuid.

2015-10-29 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39792/ --- Review request for mesos, Anand Mazumdar and Ben Mahler. Repository: mesos

Re: Review Request 39792: Updated master and slave to properly set task status uuid.

2015-10-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39792/#review104516 --- Patch looks great! Reviews applied: [39791, 39792] All tests