Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39804/#review114556
---

Ship it!


Ship It!

- Joris Van Remoortere


On Jan. 4, 2016, 6:35 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39804/
> ---
> 
> (Updated Jan. 4, 2016, 6:35 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39804/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

[Alex Naparu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39804/#review112620
---

Ship it!


Ship It!

- Alex Naparu


On Jan. 4, 2016, 6:35 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39804/
> ---
> 
> (Updated Jan. 4, 2016, 6:35 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> 14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39804/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39804/
---

(Updated Jan. 4, 2016, 11:21 a.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
a8c35c086ecae21701f6a720f25231c1b0d4e329 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
5c1df81193b4b888d2ed5c7dbfa0b5e2fae48467 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39804/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39804/
---

(Updated Jan. 4, 2016, 6:35 p.m.)


Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
b2dea9b93adfa3ea0415a0b5c81a369dd29b6cfe 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
14fbca6d222bdfc0e8be301050b4ea1a8a6e7758 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39804/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer

Re: Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39804/#review105146
---

Ship it!


Checked that code did not change in midst of the move.


3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp (line 16)


```
#include 
#include 

#include 
```



3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp (line 50)


This was originally present, but you can remove the space between the `> >`.


- Joseph Wu


On Oct. 31, 2015, 5:28 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39804/
> ---
> 
> (Updated Oct. 31, 2015, 5:28 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 67b142bbc2d80f40a1e893cc5813d58dd2aa8381 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
> fc2df6831ae2cb1a91c7a8cc92965939576e575d 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/39804/diff/
> 
> 
> Testing
> ---
> 
> `make check` from autotools on Ubuntu 15.
> `make check` from CMake on OS X 10.10.
> Ran `check` project in VS on Windows 10.
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 39804: Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39804/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph 
Wu.


Repository: mesos


Description
---

Windows: Moved `os::find` to its own file, `stout/os/find.hpp`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
67b142bbc2d80f40a1e893cc5813d58dd2aa8381 
  3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp 
fc2df6831ae2cb1a91c7a8cc92965939576e575d 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/find.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/39804/diff/


Testing
---

`make check` from autotools on Ubuntu 15.
`make check` from CMake on OS X 10.10.
Ran `check` project in VS on Windows 10.


Thanks,

Alex Clemmer