Re: Review Request 39914: Changed verify_review to use docker_build.sh.

2015-11-11 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review106127
---



support/verify_reviews.py (line 122)


there is no --enable-libev option. i will change this to --verbose when 
committing.


- Vinod Kone


On Nov. 11, 2015, 12:14 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> ---
> 
> (Updated Nov. 11, 2015, 12:14 a.m.)
> 
> 
> Review request for mesos, Cody Maloney and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> reviewbot builds dont use docker today. This change would make reviewbot 
> environment to be same as mesos builds on jenkins which  uses docker.
> 
> 
> Diffs
> -
> 
>   support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 
> 
> Diff: https://reviews.apache.org/r/39914/diff/
> 
> 
> Testing
> ---
> 
> ran script locally
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

2015-11-11 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review106125
---

Ship it!


- Vinod Kone


On Nov. 11, 2015, 12:14 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> ---
> 
> (Updated Nov. 11, 2015, 12:14 a.m.)
> 
> 
> Review request for mesos, Cody Maloney and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> reviewbot builds dont use docker today. This change would make reviewbot 
> environment to be same as mesos builds on jenkins which  uses docker.
> 
> 
> Diffs
> -
> 
>   support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 
> 
> Diff: https://reviews.apache.org/r/39914/diff/
> 
> 
> Testing
> ---
> 
> ran script locally
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

2015-11-10 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/
---

(Updated Nov. 11, 2015, 12:14 a.m.)


Review request for mesos, Cody Maloney and Vinod Kone.


Changes
---

updated description.


Repository: mesos


Description (updated)
---

reviewbot builds dont use docker today. This change would make reviewbot 
environment to be same as mesos builds on jenkins which  uses docker.


Diffs
-

  support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 

Diff: https://reviews.apache.org/r/39914/diff/


Testing
---

ran script locally


Thanks,

Jojy Varghese

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

2015-11-10 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/
---

(Updated Nov. 10, 2015, 11:46 p.m.)


Review request for mesos, Cody Maloney and Vinod Kone.


Changes
---

just keeping libev in default configuration.


Repository: mesos


Description
---

SSL based tests are not currently verified on reviewbot. This change would make 
reviewbot environment to be same as mesos builds on jenkins.


Diffs (updated)
-

  support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 

Diff: https://reviews.apache.org/r/39914/diff/


Testing
---

ran script locally


Thanks,

Jojy Varghese

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

2015-11-05 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/
---

(Updated Nov. 5, 2015, 8:12 p.m.)


Review request for mesos, Cody Maloney and Vinod Kone.


Changes
---

replaced libevent with libev as default configuration.


Repository: mesos


Description
---

SSL based tests are not currently verified on reviewbot. This change would make 
reviewbot environment to be same as mesos builds on jenkins.


Diffs (updated)
-

  support/docker_build.sh cea5eaded739bc336e818a081fa308fb6b66fbef 
  support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 

Diff: https://reviews.apache.org/r/39914/diff/


Testing
---

ran script locally


Thanks,

Jojy Varghese

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

2015-11-05 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/
---

(Updated Nov. 5, 2015, 7:44 p.m.)


Review request for mesos, Cody Maloney and Vinod Kone.


Changes
---

setting build env in the script.


Repository: mesos


Description
---

SSL based tests are not currently verified on reviewbot. This change would make 
reviewbot environment to be same as mesos builds on jenkins.


Diffs (updated)
-

  support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 

Diff: https://reviews.apache.org/r/39914/diff/


Testing
---

ran script locally


Thanks,

Jojy Varghese

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

2015-11-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review105328
---


Patch looks great!

Reviews applied: [39953, 39954, 39914]

All tests passed.

- Mesos ReviewBot


On Nov. 5, 2015, 8:12 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> ---
> 
> (Updated Nov. 5, 2015, 8:12 p.m.)
> 
> 
> Review request for mesos, Cody Maloney and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> SSL based tests are not currently verified on reviewbot. This change would 
> make reviewbot environment to be same as mesos builds on jenkins.
> 
> 
> Diffs
> -
> 
>   support/docker_build.sh cea5eaded739bc336e818a081fa308fb6b66fbef 
>   support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 
> 
> Diff: https://reviews.apache.org/r/39914/diff/
> 
> 
> Testing
> ---
> 
> ran script locally
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

2015-11-04 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/
---

(Updated Nov. 4, 2015, 8:47 p.m.)


Review request for mesos, Cody Maloney and Vinod Kone.


Changes
---

after discussion with vinod.


Summary (updated)
-

Changed verify_review to use docker_build.sh.


Repository: mesos


Description (updated)
---

SSL based tests are not currently verified on reviewbot. This change would make 
reviewbot environment to be same as mesos builds on jenkins.


Diffs (updated)
-

  support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 

Diff: https://reviews.apache.org/r/39914/diff/


Testing (updated)
---

ran script locally


Thanks,

Jojy Varghese

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

2015-11-04 Thread Jojy Varghese 


> On Nov. 4, 2015, 9:12 p.m., Vinod Kone wrote:
> > support/verify_reviews.py, line 122
> > 
> >
> > have you verified this change locally?
> > 
> > the docker_build.sh script expects certain environment variables to be 
> > set.

I ran the script locally by setting the OS, CONFIGURATION etc manually. I didnt 
know the workflow for setting these. How are these env variables set?


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review105136
---


On Nov. 4, 2015, 8:47 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> ---
> 
> (Updated Nov. 4, 2015, 8:47 p.m.)
> 
> 
> Review request for mesos, Cody Maloney and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> SSL based tests are not currently verified on reviewbot. This change would 
> make reviewbot environment to be same as mesos builds on jenkins.
> 
> 
> Diffs
> -
> 
>   support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 
> 
> Diff: https://reviews.apache.org/r/39914/diff/
> 
> 
> Testing
> ---
> 
> ran script locally
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39914: Changed verify_review to use docker_build.sh.

2015-11-04 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39914/#review105136
---



support/verify_reviews.py (line 122)


have you verified this change locally?

the docker_build.sh script expects certain environment variables to be set.


- Vinod Kone


On Nov. 4, 2015, 8:47 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39914/
> ---
> 
> (Updated Nov. 4, 2015, 8:47 p.m.)
> 
> 
> Review request for mesos, Cody Maloney and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> SSL based tests are not currently verified on reviewbot. This change would 
> make reviewbot environment to be same as mesos builds on jenkins.
> 
> 
> Diffs
> -
> 
>   support/verify_reviews.py 0d322a19af719aba8846fbc705bf8ec7647304a3 
> 
> Diff: https://reviews.apache.org/r/39914/diff/
> 
> 
> Testing
> ---
> 
> ran script locally
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>