Re: Review Request 40107: Removed unused checks in command executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40107/#review105877 --- Ship it! Ship It! - haosdent huang On Nov. 10, 2015, 1:21 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40107/ > --- > > (Updated Nov. 10, 2015, 1:21 p.m.) > > > Review request for mesos, Anand Mazumdar and Till Toenshoff. > > > Bugs: MESOS-3851 > https://issues.apache.org/jira/browse/MESOS-3851 > > > Repository: mesos > > > Description > --- > > Removed unused checks in command executor. > > > Diffs > - > > src/launcher/executor.cpp 0dad75d7d730ef6cdc4b427a358625433cfee510 > > Diff: https://reviews.apache.org/r/40107/diff/ > > > Testing > --- > > make check > > > Thanks, > > Timothy Chen > >
Re: Review Request 40107: Removed unused checks in command executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40107/#review105842 --- This is supposed to be the fix (or workaround) for MESOS-3851, right? Let's please tag it in the "bugs" section. However, just as Vinod commented in that ticket, it seems the implications of the problem might really be bigger and not only localized to tbe command executor. - Till Toenshoff On Nov. 9, 2015, 9:37 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40107/ > --- > > (Updated Nov. 9, 2015, 9:37 p.m.) > > > Review request for mesos, Anand Mazumdar and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > Removed unused checks in command executor. > > > Diffs > - > > src/launcher/executor.cpp 0dad75d7d730ef6cdc4b427a358625433cfee510 > > Diff: https://reviews.apache.org/r/40107/diff/ > > > Testing > --- > > make check > > > Thanks, > > Timothy Chen > >
Re: Review Request 40107: Removed unused checks in command executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40107/#review105872 --- Ship it! Ship It! - Till Toenshoff On Nov. 10, 2015, 1:21 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40107/ > --- > > (Updated Nov. 10, 2015, 1:21 p.m.) > > > Review request for mesos, Anand Mazumdar and Till Toenshoff. > > > Bugs: MESOS-3851 > https://issues.apache.org/jira/browse/MESOS-3851 > > > Repository: mesos > > > Description > --- > > Removed unused checks in command executor. > > > Diffs > - > > src/launcher/executor.cpp 0dad75d7d730ef6cdc4b427a358625433cfee510 > > Diff: https://reviews.apache.org/r/40107/diff/ > > > Testing > --- > > make check > > > Thanks, > > Timothy Chen > >
Re: Review Request 40107: Removed unused checks in command executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40107/ --- (Updated Nov. 10, 2015, 5:21 a.m.) Review request for mesos, Anand Mazumdar and Till Toenshoff. Changes --- Added bug number. Bugs: MESOS-3851 https://issues.apache.org/jira/browse/MESOS-3851 Repository: mesos Description --- Removed unused checks in command executor. Diffs - src/launcher/executor.cpp 0dad75d7d730ef6cdc4b427a358625433cfee510 Diff: https://reviews.apache.org/r/40107/diff/ Testing --- make check Thanks, Timothy Chen
Re: Review Request 40107: Removed unused checks in command executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40107/ --- (Updated Nov. 9, 2015, 9:37 p.m.) Review request for mesos, Anand Mazumdar and Till Toenshoff. Repository: mesos Description --- Removed unused checks in command executor. Diffs - src/launcher/executor.cpp 0dad75d7d730ef6cdc4b427a358625433cfee510 Diff: https://reviews.apache.org/r/40107/diff/ Testing (updated) --- make check Thanks, Timothy Chen
Review Request 40107: Removed unused checks in command executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40107/ --- Review request for mesos, Anand Mazumdar and Till Toenshoff. Repository: mesos Description --- Removed unused checks in command executor. Diffs - src/launcher/executor.cpp 0dad75d7d730ef6cdc4b427a358625433cfee510 Diff: https://reviews.apache.org/r/40107/diff/ Testing --- Thanks, Timothy Chen
Re: Review Request 40107: Removed unused checks in command executor.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40107/#review105760 --- Bad patch! Reviews applied: [40107] Failed command: ./support/apply-review.sh -n -r 40107 Error: 2015-11-09 22:59:50 URL:https://reviews.apache.org/r/40107/diff/raw/ [1340/1340] -> "40107.patch" [1] error: patch failed: src/launcher/executor.cpp:91 error: src/launcher/executor.cpp: patch does not apply Failed to apply patch - Mesos ReviewBot On Nov. 9, 2015, 9:37 p.m., Timothy Chen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40107/ > --- > > (Updated Nov. 9, 2015, 9:37 p.m.) > > > Review request for mesos, Anand Mazumdar and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > Removed unused checks in command executor. > > > Diffs > - > > src/launcher/executor.cpp 0dad75d7d730ef6cdc4b427a358625433cfee510 > > Diff: https://reviews.apache.org/r/40107/diff/ > > > Testing > --- > > make check > > > Thanks, > > Timothy Chen > >
