Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 22, 2015, 9:50 p.m., Joris Van Remoortere wrote: > > src/master/quota_handler.cpp, lines 324-328 > > > > > > We should set the quota before we rescind so that we avoid the race > > above ;-) > >

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 18, 2015, 7:51 a.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 180 > > > > > > Why do we want to rescind the offeres that do not contribute to > > satisfying quota request? > > Alexander

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review108075 --- Ship it! Resolved outstanding issues. - Joris Van Remoortere

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review108038 --- src/master/quota_handler.cpp (lines 211 - 212)

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 22, 2015, 9:50 p.m., Joris Van Remoortere wrote: > > src/master/quota_handler.cpp, lines 180-181 > > > > > > "Offers that do > > // not contribute to satisfying quota request will be rescinded > >

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 18, 2015, 3:51 p.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 180 > > > > > > Why do we want to rescind the offeres that do not contribute to > > satisfying quota request? > > Alexander

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 18, 2015, 7:51 a.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 180 > > > > > > Why do we want to rescind the offeres that do not contribute to > > satisfying quota request? > > Alexander

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/ --- (Updated Nov. 24, 2015, 4:29 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 23, 2015, 3:35 a.m., Guangya Liu wrote: > > src/master/quota_handler.cpp, line 332 > > > > > > s/enough/as many as? > > > > I'm proposing this because we cannot guarantee there are enough > >

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 18, 2015, 3:51 p.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 180 > > > > > > Why do we want to rescind the offeres that do not contribute to > > satisfying quota request? > > Alexander

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/ --- (Updated Nov. 23, 2015, 12:57 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review107545 --- src/master/quota_handler.cpp (line 332)

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review107520 --- src/master/master.hpp (line 898)

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 18, 2015, 7:51 a.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 180 > > > > > > Why do we want to rescind the offeres that do not contribute to > > satisfying quota request? > > Alexander

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 18, 2015, 3:51 p.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 180 > > > > > > Why do we want to rescind the offeres that do not contribute to > > satisfying quota request? > > Alexander

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/ --- (Updated Nov. 19, 2015, 5:01 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/ --- (Updated Nov. 19, 2015, 5:10 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 17, 2015, 6:16 a.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 211 > > > > > > For ```offer->resources()```, before doing the math, do we need to call > > ```flatten()``` to remove role

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 18, 2015, 7:51 a.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 180 > > > > > > Why do we want to rescind the offeres that do not contribute to > > satisfying quota request? Because we may

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

> On Nov. 17, 2015, 6:16 a.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 171 > > > > > > For ```request.guarantee()```, I think we need to call ```flatten()``` > > to remove role first. That's

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review106977 --- src/master/master.hpp (line 904)

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/ --- (Updated Nov. 17, 2015, 8:15 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/ --- (Updated Nov. 16, 2015, 4:46 p.m.) Review request for mesos, Bernd Mathiske,

Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere,

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review106672 --- Bad patch! Reviews applied: [39211, 39018, 39102, 36913] Failed

Re: Review Request 40351: Quota: Added rescinding offers for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review106799 --- src/master/quota_handler.cpp (line 171)