Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

2016-10-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/ --- (Updated Oct. 12, 2016, 2:25 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

2016-10-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/#review152051 --- 3rdparty/libprocess/include/process/metrics/metrics.hpp (lines

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

2016-10-10 Thread Joseph Wu
> On Oct. 10, 2016, 12:22 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/metrics/metrics.cpp, line 106 > > > > > > so MetricsProcess was not managed by gc before? was that a bug? It was never cleaned up and

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

2016-10-10 Thread Vinod Kone
> On Oct. 10, 2016, 7:22 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/include/process/metrics/metrics.hpp, line 95 > > > > > > we don't name other global processes singletons, so i would just call > > this

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

2016-10-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/#review152045 --- Fix it, then Ship it!

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

2016-09-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/#review149913 --- Ship it! Ship It! - Greg Mann On July 29, 2016, 11:56 p.m.,

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

2016-07-29 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/ --- (Updated July 29, 2016, 4:56 p.m.) Review request for mesos, Greg Mann, Artem

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

2016-07-27 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/#review143866 --- 3rdparty/libprocess/include/process/metrics/metrics.hpp (line

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

2016-07-26 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/ --- (Updated July 26, 2016, 2:13 p.m.) Review request for mesos, Artem Harutyunyan

Re: Review Request 40410: Libprocess Reinit: Move MetricsProcess instantiation into process.cpp.

2016-04-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40410/ --- (Updated April 14, 2016, 1:28 p.m.) Review request for mesos, Artem