Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-12-03 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/#review108792 --- Ship it! Ship It! - Gilbert Song On Dec. 2, 2015, 10:28 p.m.,

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-12-03 Thread Michael Park
> On Dec. 3, 2015, 4:26 a.m., Michael Park wrote: > > Could you also create a clean-up patch to get rid of the unnecessary > > `struct` disambiguators in this file? > > Neil Conway wrote: > I kinda like leaving "struct" as-is, because we're interfacing with > C-style APIs where "struct"

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-12-03 Thread Neil Conway
> On Dec. 3, 2015, 4:26 a.m., Michael Park wrote: > > Could you also create a clean-up patch to get rid of the unnecessary > > `struct` disambiguators in this file? > > Neil Conway wrote: > I kinda like leaving "struct" as-is, because we're interfacing with > C-style APIs where "struct"

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-12-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/ --- (Updated Dec. 3, 2015, 6:28 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-12-02 Thread Neil Conway
> On Dec. 3, 2015, 4:26 a.m., Michael Park wrote: > > Could you also create a clean-up patch to get rid of the unnecessary > > `struct` disambiguators in this file? I kinda like leaving "struct" as-is, because we're interfacing with C-style APIs where "struct" is syntactically significant --

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-12-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/#review108770 --- Patch looks great! Reviews applied: [40435] Passed command:

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-12-02 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/#review108773 --- Ship it! Could you also create a clean-up patch to get rid of the

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-12-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/ --- (Updated Dec. 3, 2015, 1:45 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-11-19 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/#review107154 --- Ship it! - Benjamin Bannier On Nov. 18, 2015, 11:09 a.m., Neil

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-11-19 Thread Benjamin Bannier
> On Nov. 18, 2015, 10:57 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 233 > > > > > > You didn't start this, but any `struct` token here is unnecessary noise > >

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-11-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/#review107000 --- 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp (line

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-11-18 Thread Neil Conway
> On Nov. 18, 2015, 10:57 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/ip.hpp, line 233 > > > > > > You didn't start this, but any `struct` token here is unnecessary noise > >

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-11-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/ --- (Updated Nov. 18, 2015, 11:09 a.m.) Review request for mesos, Benjamin

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-11-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/#review107013 --- Patch looks great! Reviews applied: [40435] Passed command:

Re: Review Request 40435: Fixed pointer alignment error in IP::create().

2015-11-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/#review107004 --- Patch looks great! Reviews applied: [40435] Passed command:

Review Request 40435: Fixed pointer alignment error in IP::create().

2015-11-18 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40435/ --- Review request for mesos, Benjamin Bannier, Ben Mahler, and Niklas Nielsen.