Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

> On Nov. 26, 2015, 6:43 a.m., Alexander Rukletsov wrote: > > src/common/resources.cpp, line 35 > > > > > > Is it fine to include files from "master/" in "common/*"? Addressed in https://reviews.apache.org/r/40767/

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

> On Nov. 26, 2015, 6:20 a.m., Bernd Mathiske wrote: > > Ship It! An addendum intended to address the issues below is available here: https://reviews.apache.org/r/40767/ - Bernd --- This is an automatically generated e-mail. To reply,

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

> On Nov. 26, 2015, 3:14 p.m., Neil Conway wrote: > > src/common/resources.cpp, line 951 > > > > > > This definitely needs an explanatory comment. > > Bernd Mathiske wrote: > I'll propose a patch that addresses

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

> On Nov. 26, 2015, 7:14 a.m., Neil Conway wrote: > > src/common/resources.cpp, line 951 > > > > > > This definitely needs an explanatory comment. I'll propose a patch that addresses these issues. - Bernd --

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/#review108140 --- src/common/resources.cpp (line 949)

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/#review108136 --- Ship it! Ship It! - Klaus Ma On Nov. 26, 2015, 2:52 p.m., Avina

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/#review108134 --- Sorry for multiple shards instead of a single review. src/common/

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/#review108133 --- src/common/resources.cpp

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/#review108132 --- src/common/resources.cpp (line 35)

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

> On Nov. 26, 2015, 6:27 a.m., Till Toenshoff wrote: > > src/common/resources.cpp, line 947 > > > > > > Why introducing the leading space after the bracket? > > > > s/CHECK( /CHECK(/g I will fix this when c

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/#review108130 --- Ship it! Thanks a bunch for coming up with this short-term-fix, Av

Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/#review108129 --- Ship it! Ship It! - Bernd Mathiske On Nov. 25, 2015, 10:52 p.m.

Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to avoid errors due to double precision errors.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40730/ --- Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway. Bugs: MESO