Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.

2016-01-27 Thread Alex Clemmer
> On Jan. 27, 2016, 3 a.m., Alex Clemmer wrote: > > Aside from the relatively minor comments below, I have one major > > suggestion: I'd like to point Windows builds at ZK commit > > 06d3f3fa1bff258e62c0670309ad1849b1434bb1[1], (or _some_ commit later in the > > version history) so that we

Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.

2016-01-26 Thread M Lawindi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40851/ --- (Updated Jan. 26, 2016, 8:18 p.m.) Review request for mesos, Alex Naparu,

Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.

2016-01-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40851/#review116447 --- Bad patch! Reviews applied: [39850, 39851, 39852, 39888, 39889,

Re: Review Request 40851: Windows:[1/2] Updated zookeeper-3.4.5.patch to fix VS2015 build.

2016-01-25 Thread M Lawindi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40851/ --- (Updated Jan. 25, 2016, 11:21 p.m.) Review request for mesos, Alex Naparu,