Re: Review Request 40873: RegistryClientTests: Created separate server to serve blobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40873/#review109716 --- Ship it! Ship It! - Timothy Chen On Dec. 3, 2015, 5:20 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40873/ > --- > > (Updated Dec. 3, 2015, 5:20 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-4025 > https://issues.apache.org/jira/browse/MESOS-4025 > > > Repository: mesos > > > Description > --- > > By having a separate blob server, it simulates the real world more closely. > It also allows the test server to be in accept mode early. > > > Diffs > - > > src/tests/containerizer/provisioner_docker_tests.cpp > c63bf53fee40ef12536a16e11f4d5224c4e4278e > > Diff: https://reviews.apache.org/r/40873/diff/ > > > Testing > --- > > make check (600 count). > > > Thanks, > > Jojy Varghese > >
Re: Review Request 40873: RegistryClientTests: Created separate server to serve blobs.
> On Dec. 3, 2015, 6:21 p.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [40872, 40873] > > > > Passed command: export OS=ubuntu:14.04;export > > CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh What does simulates the real world more closely mean here? - Timothy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40873/#review108853 --- On Dec. 3, 2015, 5:20 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40873/ > --- > > (Updated Dec. 3, 2015, 5:20 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-4025 > https://issues.apache.org/jira/browse/MESOS-4025 > > > Repository: mesos > > > Description > --- > > By having a separate blob server, it simulates the real world more closely. > It also allows the test server to be in accept mode early. > > > Diffs > - > > src/tests/containerizer/provisioner_docker_tests.cpp > c63bf53fee40ef12536a16e11f4d5224c4e4278e > > Diff: https://reviews.apache.org/r/40873/diff/ > > > Testing > --- > > make check (600 count). > > > Thanks, > > Jojy Varghese > >
Re: Review Request 40873: RegistryClientTests: Created separate server to serve blobs.
> On Dec. 3, 2015, 6:21 p.m., Mesos ReviewBot wrote: > > Patch looks great! > > > > Reviews applied: [40872, 40873] > > > > Passed command: export OS=ubuntu:14.04;export > > CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh > > Timothy Chen wrote: > What does simulates the real world more closely mean here? The change introduces a new server to serve the blobs like how the docker registry has a blob server (where the blob request is rediercted to). - Jojy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40873/#review108853 --- On Dec. 3, 2015, 5:20 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40873/ > --- > > (Updated Dec. 3, 2015, 5:20 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-4025 > https://issues.apache.org/jira/browse/MESOS-4025 > > > Repository: mesos > > > Description > --- > > By having a separate blob server, it simulates the real world more closely. > It also allows the test server to be in accept mode early. > > > Diffs > - > > src/tests/containerizer/provisioner_docker_tests.cpp > c63bf53fee40ef12536a16e11f4d5224c4e4278e > > Diff: https://reviews.apache.org/r/40873/diff/ > > > Testing > --- > > make check (600 count). > > > Thanks, > > Jojy Varghese > >
Re: Review Request 40873: RegistryClientTests: Created separate server to serve blobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40873/ --- (Updated Dec. 3, 2015, 5:20 p.m.) Review request for mesos and Timothy Chen. Summary (updated) - RegistryClientTests: Created separate server to serve blobs. Bugs: MESOS-4025 https://issues.apache.org/jira/browse/MESOS-4025 Repository: mesos Description (updated) --- By having a separate blob server, it simulates the real world more closely. It also allows the test server to be in accept mode early. Diffs (updated) - src/tests/containerizer/provisioner_docker_tests.cpp c63bf53fee40ef12536a16e11f4d5224c4e4278e Diff: https://reviews.apache.org/r/40873/diff/ Testing --- make check (600 count). Thanks, Jojy Varghese
Re: Review Request 40873: RegistryClientTests: Created separate server to serve blobs.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40873/#review108853 --- Patch looks great! Reviews applied: [40872, 40873] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Dec. 3, 2015, 5:20 p.m., Jojy Varghese wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40873/ > --- > > (Updated Dec. 3, 2015, 5:20 p.m.) > > > Review request for mesos and Timothy Chen. > > > Bugs: MESOS-4025 > https://issues.apache.org/jira/browse/MESOS-4025 > > > Repository: mesos > > > Description > --- > > By having a separate blob server, it simulates the real world more closely. > It also allows the test server to be in accept mode early. > > > Diffs > - > > src/tests/containerizer/provisioner_docker_tests.cpp > c63bf53fee40ef12536a16e11f4d5224c4e4278e > > Diff: https://reviews.apache.org/r/40873/diff/ > > > Testing > --- > > make check (600 count). > > > Thanks, > > Jojy Varghese > >
