Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

2015-12-30 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/
---

(Updated Dec. 30, 2015, 8:47 p.m.)


Review request for mesos, Ben Mahler and Jie Yu.


Changes
---

Jie correctly spotted that we can land into `escalationTimeout` via `killTask` 
and `shutdown`. Not a good place to be. Removed the two states for now. Would 
put them back in a subsequent review.


Bugs: MESOS-3851
https://issues.apache.org/jira/browse/MESOS-3851


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/launcher/executor.cpp 09e7de6f2136ed9ca13e4822aeabcba2f7c5837d 

Diff: https://reviews.apache.org/r/40998/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

2015-12-30 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/#review112337
---

Ship it!



src/launcher/executor.cpp (line 106)


use CHECK_EQ? Here and everywhere else.



src/launcher/executor.cpp (line 618)


s/RUNNING/REGISTERED/?


- Jie Yu


On Dec. 30, 2015, 6:39 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40998/
> ---
> 
> (Updated Dec. 30, 2015, 6:39 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-3851
> https://issues.apache.org/jira/browse/MESOS-3851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp f90ea01131e6fa28e42f0c00a317d66a49f81ffa 
> 
> Diff: https://reviews.apache.org/r/40998/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

2015-12-30 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/
---

(Updated Dec. 30, 2015, 8:06 p.m.)


Review request for mesos, Ben Mahler and Jie Yu.


Changes
---

Review comments from Jie.


Bugs: MESOS-3851
https://issues.apache.org/jira/browse/MESOS-3851


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/launcher/executor.cpp 09e7de6f2136ed9ca13e4822aeabcba2f7c5837d 

Diff: https://reviews.apache.org/r/40998/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

2015-12-30 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/#review112348
---


Patch looks great!

Reviews applied: [40998]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 30, 2015, 8:47 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40998/
> ---
> 
> (Updated Dec. 30, 2015, 8:47 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Jie Yu.
> 
> 
> Bugs: MESOS-3851
> https://issues.apache.org/jira/browse/MESOS-3851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp 09e7de6f2136ed9ca13e4822aeabcba2f7c5837d 
> 
> Diff: https://reviews.apache.org/r/40998/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

2015-12-07 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/#review109284
---


Patch looks great!

Reviews applied: [40998]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 7, 2015, 11:19 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40998/
> ---
> 
> (Updated Dec. 7, 2015, 11:19 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-3851
> https://issues.apache.org/jira/browse/MESOS-3851
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/launcher/executor.cpp f90ea01131e6fa28e42f0c00a317d66a49f81ffa 
> 
> Diff: https://reviews.apache.org/r/40998/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 40998: Added CHECK's for various executor states in Command Executor to verify if messages are delivered in order.

2015-12-07 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40998/
---

(Updated Dec. 7, 2015, 11:19 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

Changes based on feedback from BenM around not using an unused variable 
`executorInfo` but introduing an `State` enum.


Summary (updated)
-

Added CHECK's for various executor states in Command Executor to verify if 
messages are delivered in order.


Bugs: MESOS-3851
https://issues.apache.org/jira/browse/MESOS-3851


Repository: mesos


Description (updated)
---

See summary.


Diffs (updated)
-

  src/launcher/executor.cpp f90ea01131e6fa28e42f0c00a317d66a49f81ffa 

Diff: https://reviews.apache.org/r/40998/diff/


Testing
---

make check


Thanks,

Anand Mazumdar