Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.

2015-12-07 Thread Till Toenshoff 


> On Dec. 8, 2015, 1 a.m., Michael Park wrote:
> > include/mesos/v1/mesos.proto, lines 1507-1508
> > 
> >
> > It looks like we're also missing this from `include/mesos/mesos.proto`?
> > ```
> > 1510 // The name of volume driver plugin.
> > 1511 optional string volume_driver = 7;
> > ```
> 
> Till Toenshoff wrote:
> That one was brought in by commit 
> fc7e25d8c05ee3c226e4d45819c047009ddd71c0, which is RR 
> https://reviews.apache.org/r/38338, backed by 
> https://issues.apache.org/jira/browse/MESOS-3392.
> 
> It got in after the release-cut, so it is not a problem for 0.26.0 but 
> following releases.
> 
> Will drop this issue for this one as it was marked as based on 0.26.0-rc3 
> but add a new RR which is a complete fix for the current master.

See https://reviews.apache.org/r/41070/


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41060/#review109229
---


On Dec. 8, 2015, 2:06 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41060/
> ---
> 
> (Updated Dec. 8, 2015, 2:06 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copied missing feature updates to v1 from include/mesos/mesos.proto.
> 
> This is a revised version of RR 41046 - removing the `AppcImageManifest` from 
> V1 API again as it has been intensionally left out (as being Slave only).
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto be3d61e9ec2f092019d6111d6e08b06fcc6dd068 
> 
> Diff: https://reviews.apache.org/r/41060/diff/
> 
> 
> Testing
> ---
> 
> For achieving this, the following was done within the tagged 0.26.0-rc3:
> 
> `diff include/mesos/mesos.proto include/mesos/v1/mesos.proto`
> `diff include/mesos/executor.proto include/mesos/v1/executor.proto`
> `diff include/mesos/scheduler/scheduler.proto 
> include/mesos/v1/scheduler/scheduler.proto`
> 
> These diffs do show a couple of "slave"->"agent" renames which were ignored 
> for this udate.
> 
> The results showed that only mesos.proto was not en par with V1. We listed 
> out all responsible review-requests;
> https://reviews.apache.org/r/31915
> https://reviews.apache.org/r/38253
> https://reviews.apache.org/r/38367
> 
> Parity on message definitions that are not purely slave related should now be 
> achieved by this RR.
> 
> We did however notice a irregularity on the non v1-proto, documented by 
> https://issues.apache.org/jira/browse/MESOS-4091
> 
> make check (on OSX)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.

2015-12-07 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41060/
---

(Updated Dec. 8, 2015, 2:23 a.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Joris Van Remoortere.


Repository: mesos


Description
---

Copied missing feature updates to v1 from include/mesos/mesos.proto.

This is a revised version of RR 41046 - removing the `AppcImageManifest` from 
V1 API again as it has been intensionally left out (as being Slave only).


Diffs (updated)
-

  include/mesos/v1/mesos.proto be3d61e9ec2f092019d6111d6e08b06fcc6dd068 

Diff: https://reviews.apache.org/r/41060/diff/


Testing
---

For achieving this, the following was done within the tagged 0.26.0-rc3:

`diff include/mesos/mesos.proto include/mesos/v1/mesos.proto`
`diff include/mesos/executor.proto include/mesos/v1/executor.proto`
`diff include/mesos/scheduler/scheduler.proto 
include/mesos/v1/scheduler/scheduler.proto`

These diffs do show a couple of "slave"->"agent" renames which were ignored for 
this udate.

The results showed that only mesos.proto was not en par with V1. We listed out 
all responsible review-requests;
https://reviews.apache.org/r/31915
https://reviews.apache.org/r/38253
https://reviews.apache.org/r/38367

Parity on message definitions that are not purely slave related should now be 
achieved by this RR.

We did however notice a irregularity on the non v1-proto, documented by 
https://issues.apache.org/jira/browse/MESOS-4091

make check (on OSX)


Thanks,

Till Toenshoff

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.

2015-12-07 Thread Till Toenshoff 


> On Dec. 8, 2015, 1 a.m., Michael Park wrote:
> > include/mesos/v1/mesos.proto, lines 1507-1508
> > 
> >
> > It looks like we're also missing this from `include/mesos/mesos.proto`?
> > ```
> > 1510 // The name of volume driver plugin.
> > 1511 optional string volume_driver = 7;
> > ```
> 
> Till Toenshoff wrote:
> That one was brought in by commit 
> fc7e25d8c05ee3c226e4d45819c047009ddd71c0, which is RR 
> https://reviews.apache.org/r/38338, backed by 
> https://issues.apache.org/jira/browse/MESOS-3392.
> 
> It got in after the release-cut, so it is not a problem for 0.26.0 but 
> following releases.
> 
> Will drop this issue for this one as it was marked as based on 0.26.0-rc3 
> but add a new RR which is a complete fix for the current master.
> 
> Till Toenshoff wrote:
> See https://reviews.apache.org/r/41070/

Actually, scratch 41070 - that partity is brought in by 
https://reviews.apache.org/r/40888


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41060/#review109229
---


On Dec. 8, 2015, 2:23 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41060/
> ---
> 
> (Updated Dec. 8, 2015, 2:23 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copied missing feature updates to v1 from include/mesos/mesos.proto.
> 
> This is a revised version of RR 41046 - removing the `AppcImageManifest` from 
> V1 API again as it has been intensionally left out (as being Slave only).
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto be3d61e9ec2f092019d6111d6e08b06fcc6dd068 
> 
> Diff: https://reviews.apache.org/r/41060/diff/
> 
> 
> Testing
> ---
> 
> For achieving this, the following was done within the tagged 0.26.0-rc3:
> 
> `diff include/mesos/mesos.proto include/mesos/v1/mesos.proto`
> `diff include/mesos/executor.proto include/mesos/v1/executor.proto`
> `diff include/mesos/scheduler/scheduler.proto 
> include/mesos/v1/scheduler/scheduler.proto`
> 
> These diffs do show a couple of "slave"->"agent" renames which were ignored 
> for this udate.
> 
> The results showed that only mesos.proto was not en par with V1. We listed 
> out all responsible review-requests;
> https://reviews.apache.org/r/31915
> https://reviews.apache.org/r/38253
> https://reviews.apache.org/r/38367
> 
> Parity on message definitions that are not purely slave related should now be 
> achieved by this RR.
> 
> We did however notice a irregularity on the non v1-proto, documented by 
> https://issues.apache.org/jira/browse/MESOS-4091
> 
> make check (on OSX)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.

2015-12-07 Thread Michael Park 


> On Dec. 8, 2015, 1 a.m., Michael Park wrote:
> > include/mesos/v1/mesos.proto, lines 1507-1508
> > 
> >
> > It looks like we're also missing this from `include/mesos/mesos.proto`?
> > ```
> > 1510 // The name of volume driver plugin.
> > 1511 optional string volume_driver = 7;
> > ```
> 
> Till Toenshoff wrote:
> That one was brought in by commit 
> fc7e25d8c05ee3c226e4d45819c047009ddd71c0, which is RR 
> https://reviews.apache.org/r/38338, backed by 
> https://issues.apache.org/jira/browse/MESOS-3392.
> 
> It got in after the release-cut, so it is not a problem for 0.26.0 but 
> following releases.
> 
> Will drop this issue for this one as it was marked as based on 0.26.0-rc3 
> but add a new RR which is a complete fix for the current master.
> 
> Till Toenshoff wrote:
> See https://reviews.apache.org/r/41070/
> 
> Till Toenshoff wrote:
> Actually, scratch 41070 - that partity is brought in by 
> https://reviews.apache.org/r/40888

Saw that. Thank you!


- Michael


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41060/#review109229
---


On Dec. 8, 2015, 2:23 a.m., Till Toenshoff wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41060/
> ---
> 
> (Updated Dec. 8, 2015, 2:23 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Joris Van 
> Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Copied missing feature updates to v1 from include/mesos/mesos.proto.
> 
> This is a revised version of RR 41046 - removing the `AppcImageManifest` from 
> V1 API again as it has been intensionally left out (as being Slave only).
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto be3d61e9ec2f092019d6111d6e08b06fcc6dd068 
> 
> Diff: https://reviews.apache.org/r/41060/diff/
> 
> 
> Testing
> ---
> 
> For achieving this, the following was done within the tagged 0.26.0-rc3:
> 
> `diff include/mesos/mesos.proto include/mesos/v1/mesos.proto`
> `diff include/mesos/executor.proto include/mesos/v1/executor.proto`
> `diff include/mesos/scheduler/scheduler.proto 
> include/mesos/v1/scheduler/scheduler.proto`
> 
> These diffs do show a couple of "slave"->"agent" renames which were ignored 
> for this udate.
> 
> The results showed that only mesos.proto was not en par with V1. We listed 
> out all responsible review-requests;
> https://reviews.apache.org/r/31915
> https://reviews.apache.org/r/38253
> https://reviews.apache.org/r/38367
> 
> Parity on message definitions that are not purely slave related should now be 
> achieved by this RR.
> 
> We did however notice a irregularity on the non v1-proto, documented by 
> https://issues.apache.org/jira/browse/MESOS-4091
> 
> make check (on OSX)
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>

Re: Review Request 41060: Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.

2015-12-07 Thread Till Toenshoff 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41060/
---

(Updated Dec. 8, 2015, 2:06 a.m.)


Review request for mesos, Bernd Mathiske, Ben Mahler, and Joris Van Remoortere.


Summary (updated)
-

Made v1 API in mesos.proto equivalent to non-v1 for 0.26.0.


Repository: mesos


Description
---

Copied missing feature updates to v1 from include/mesos/mesos.proto.

This is a revised version of RR 41046 - removing the `AppcImageManifest` from 
V1 API again as it has been intensionally left out (as being Slave only).


Diffs (updated)
-

  include/mesos/v1/mesos.proto be3d61e9ec2f092019d6111d6e08b06fcc6dd068 

Diff: https://reviews.apache.org/r/41060/diff/


Testing
---

For achieving this, the following was done within the tagged 0.26.0-rc3:

`diff include/mesos/mesos.proto include/mesos/v1/mesos.proto`
`diff include/mesos/executor.proto include/mesos/v1/executor.proto`
`diff include/mesos/scheduler/scheduler.proto 
include/mesos/v1/scheduler/scheduler.proto`

These diffs do show a couple of "slave"->"agent" renames which were ignored for 
this udate.

The results showed that only mesos.proto was not en par with V1. We listed out 
all responsible review-requests;
https://reviews.apache.org/r/31915
https://reviews.apache.org/r/38253
https://reviews.apache.org/r/38367

Parity on message definitions that are not purely slave related should now be 
achieved by this RR.

We did however notice a irregularity on the non v1-proto, documented by 
https://issues.apache.org/jira/browse/MESOS-4091

make check (on OSX)


Thanks,

Till Toenshoff