Re: Review Request 41090: Second iteration of changes for cmake build on linux.

2015-12-09 Thread Alex Clemmer
> On Dec. 8, 2015, 6:18 p.m., Joseph Wu wrote: > > src/slave/cmake/FindCurl.cmake, line 28 > > > > > > (I'm a bit of a CMake noob.) Where is this defined? `find_package` is a built-in, and when you define a macro

Re: Review Request 41090: Second iteration of changes for cmake build on linux.

2015-12-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/#review109543 --- src/slave/cmake/FindCurl.cmake (line 18)

Review Request 41090: Second iteration of changes for cmake build on linux.

2015-12-08 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van

Re: Review Request 41090: Second iteration of changes for cmake build on linux.

2015-12-08 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/ --- (Updated Dec. 8, 2015, 5:52 p.m.) Review request for mesos, Artem Harutyunyan,

Re: Review Request 41090: Second iteration of changes for cmake build on linux.

2015-12-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/#review109354 --- Initial review. I haven't applied/tested this patche yet. --- I'd

Re: Review Request 41090: Second iteration of changes for cmake build on linux.

2015-12-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/#review109360 --- src/slave/cmake/FindCurl.cmake (line 111)

Re: Review Request 41090: Second iteration of changes for cmake build on linux.

2015-12-08 Thread Diana Arroyo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41090/ --- (Updated Dec. 9, 2015, 3:45 a.m.) Review request for mesos, Artem Harutyunyan,