Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

2016-01-04 Thread Michael Park
> On Dec. 18, 2015, 1:44 p.m., Benjamin Bannier wrote: > > include/mesos/type_utils.hpp, line 26 > > > > > > Looks like a forward decl is good enough here. > > Alexander Rukletsov wrote: > I'm not sure we can for

Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

2016-01-04 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41511/#review112534 --- Ship it! Ship It! - Michael Park On Dec. 22, 2015, 5:55 p.m., A

Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

2015-12-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41511/ --- (Updated Dec. 22, 2015, 5:55 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

2015-12-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41511/ --- (Updated Dec. 22, 2015, 5:52 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

2015-12-22 Thread Alexander Rukletsov
> On Dec. 18, 2015, 1:44 p.m., Benjamin Bannier wrote: > > include/mesos/type_utils.hpp, line 26 > > > > > > Looks like a forward decl is good enough here. I'm not sure we can forward declare it since it's a template

Re: Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

2015-12-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41511/#review81 --- Ship it! include/mesos/type_utils.hpp (line 26)

Review Request 41511: Cleaned up STL I/O includes in public header (including v1).

2015-12-17 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41511/ --- Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael Pa