Re: Review Request 41512: Cleaned up STL I/O includes in public headers which are not part of v1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41512/#review112535 --- Ship it! Ship It! - Michael Park On Dec. 22, 2015, 5:56 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41512/ > --- > > (Updated Dec. 22, 2015, 5:56 p.m.) > > > Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael > Park. > > > Bugs: MESOS-4183 > https://issues.apache.org/jira/browse/MESOS-4183 > > > Repository: mesos > > > Description > --- > > Where possible move `operator<<` definitions and functions using streams > to ".cpp" files and include in ".hpp"s. Also remove unused I/O > includes, add necessary includes, clean up `std::` prefixes. > > > Diffs > - > > include/mesos/authorizer/authorizer.hpp > 19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 > include/mesos/http.hpp 8529ed0bf5b0954a223af5f7025fcd0d54c7348d > include/mesos/uri/uri.hpp aa3ab5d24bb8c501dd19e93d7563cb0afd889f23 > src/authorizer/authorizer.cpp 31712e511cdaac3f6d137f425d5cd430434544aa > src/common/http.cpp 2ecb78c582325c3e5141a9946516d6c9e8d7106f > > Diff: https://reviews.apache.org/r/41512/diff/ > > > Testing > --- > > make check on Mac OS 10.10.4. > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 41512: Cleaned up STL I/O includes in public headers which are not part of v1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41512/ --- (Updated Dec. 22, 2015, 5:56 p.m.) Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael Park. Changes --- Rebased & wrapped description. Bugs: MESOS-4183 https://issues.apache.org/jira/browse/MESOS-4183 Repository: mesos Description (updated) --- Where possible move `operator<<` definitions and functions using streams to ".cpp" files and include in ".hpp"s. Also remove unused I/O includes, add necessary includes, clean up `std::` prefixes. Diffs (updated) - include/mesos/authorizer/authorizer.hpp 19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 include/mesos/http.hpp 8529ed0bf5b0954a223af5f7025fcd0d54c7348d include/mesos/uri/uri.hpp aa3ab5d24bb8c501dd19e93d7563cb0afd889f23 src/authorizer/authorizer.cpp 31712e511cdaac3f6d137f425d5cd430434544aa src/common/http.cpp 2ecb78c582325c3e5141a9946516d6c9e8d7106f Diff: https://reviews.apache.org/r/41512/diff/ Testing --- make check on Mac OS 10.10.4. Thanks, Alexander Rukletsov
Re: Review Request 41512: Cleaned up STL I/O includes in public headers which are not part of v1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41512/#review85 --- Ship it! - Benjamin Bannier On Dec. 17, 2015, 2:37 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41512/ > --- > > (Updated Dec. 17, 2015, 2:37 p.m.) > > > Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael > Park. > > > Bugs: MESOS-4183 > https://issues.apache.org/jira/browse/MESOS-4183 > > > Repository: mesos > > > Description > --- > > Where possible move `operator<<` definitions and functions using streams to > ".cpp" files and include `` in ".hpp"s. Also remove unused I/O > includes, add necessary includes, clean up `std::` prefixes. > > > Diffs > - > > include/mesos/authorizer/authorizer.hpp > ec3d3e9c9bae461c8cd136f17cfda58e0cbd4e1b > include/mesos/http.hpp 8529ed0bf5b0954a223af5f7025fcd0d54c7348d > include/mesos/uri/uri.hpp aa3ab5d24bb8c501dd19e93d7563cb0afd889f23 > src/authorizer/authorizer.cpp 31712e511cdaac3f6d137f425d5cd430434544aa > src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 > > Diff: https://reviews.apache.org/r/41512/diff/ > > > Testing > --- > > make check on Mac OS 10.10.4. > > > Thanks, > > Alexander Rukletsov > >
Review Request 41512: Cleaned up STL I/O includes in public headers which are not part of v1.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41512/ --- Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael Park. Bugs: MESOS-4183 https://issues.apache.org/jira/browse/MESOS-4183 Repository: mesos Description --- Where possible move `operator<<` definitions and functions using streams to ".cpp" files and include `` in ".hpp"s. Also remove unused I/O includes, add necessary includes, clean up `std::` prefixes. Diffs - include/mesos/authorizer/authorizer.hpp ec3d3e9c9bae461c8cd136f17cfda58e0cbd4e1b include/mesos/http.hpp 8529ed0bf5b0954a223af5f7025fcd0d54c7348d include/mesos/uri/uri.hpp aa3ab5d24bb8c501dd19e93d7563cb0afd889f23 src/authorizer/authorizer.cpp 31712e511cdaac3f6d137f425d5cd430434544aa src/common/http.cpp 5198650ba6dc1ea3dab7912e5ef6e375bf9acc96 Diff: https://reviews.apache.org/r/41512/diff/ Testing --- make check on Mac OS 10.10.4. Thanks, Alexander Rukletsov
