Re: Review Request 41539: Enabled agent do not kill exeucutor for some error cases.

2015-12-21 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41539/#review111550
---

Ship it!


Ship It!

- Joris Van Remoortere


On Dec. 18, 2015, 5:38 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41539/
> ---
> 
> (Updated Dec. 18, 2015, 5:38 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled agent do not kill exeucutor for some error cases.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp ef869695ffeb2e6d9ef0a78ddb676b1b7cd19afe 
> 
> Diff: https://reviews.apache.org/r/41539/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Re: Review Request 41539: Enabled agent do not kill exeucutor for some error cases.

2015-12-17 Thread Klaus Ma

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41539/#review19
---

Ship it!


Ship It!

- Klaus Ma


On Dec. 18, 2015, 1:38 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41539/
> ---
> 
> (Updated Dec. 18, 2015, 1:38 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled agent do not kill exeucutor for some error cases.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp ef869695ffeb2e6d9ef0a78ddb676b1b7cd19afe 
> 
> Diff: https://reviews.apache.org/r/41539/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>



Review Request 41539: Enabled agent do not kill exeucutor for some error cases.

2015-12-17 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41539/
---

Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, 
Joseph Wu, Klaus Ma, and Jian Qiu.


Repository: mesos


Description
---

Enabled agent do not kill exeucutor for some error cases.


Diffs
-

  src/slave/slave.cpp ef869695ffeb2e6d9ef0a78ddb676b1b7cd19afe 

Diff: https://reviews.apache.org/r/41539/diff/


Testing
---

make
make check


Thanks,

Guangya Liu



Re: Review Request 41539: Enabled agent do not kill exeucutor for some error cases.

2015-12-17 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41539/#review33
---


Patch looks great!

Reviews applied: [41539]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 18, 2015, 5:38 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41539/
> ---
> 
> (Updated Dec. 18, 2015, 5:38 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled agent do not kill exeucutor for some error cases.
> 
> 
> Diffs
> -
> 
>   src/slave/slave.cpp ef869695ffeb2e6d9ef0a78ddb676b1b7cd19afe 
> 
> Diff: https://reviews.apache.org/r/41539/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>