Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/#review112802 --- 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 5, 2016, 10:19 a.m.) Review request for mesos and Benjamin

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 4, 2016, 7:28 p.m.) Review request for mesos and Benjamin

Re: Review Request 41593: stout: Added `jsonify` function.

> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, lines 58-63 > > > > > > An implicit cast operator that is non-const is always code smell > >

Re: Review Request 41593: stout: Added `jsonify` function.

> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 116 > > > > > > Why not s/: Writer/: public Writer/ here and elsewhere? > > Michael Park

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 4, 2016, 7:23 p.m.) Review request for mesos and Benjamin

Re: Review Request 41593: stout: Added `jsonify` function.

> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 84 > > > > > > Did you mean to mark this a friend? Is this supposed to be static? Is > >

Re: Review Request 41593: stout: Added `jsonify` function.

> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 120 > > > > > > It seems weird to not be making this virtual ... > > Michael Park wrote:

Re: Review Request 41593: stout: Added `jsonify` function.

> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 167 > > > > > > Is the `int32_t`, `uint32_t`, and `float` overloads necessary? > >

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Jan. 4, 2016, 11:39 p.m.) Review request for mesos and Benjamin

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 23, 2015, 5:57 p.m.) Review request for mesos and Benjamin

Re: Review Request 41593: stout: Added `jsonify` function.

> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 536 > > > > > > Do you think the comment over `WriterProxy` will be sufficient to > >

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 22, 2015, 8:39 p.m.) Review request for mesos and Benjamin

Re: Review Request 41593: stout: Added `jsonify` function.

> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 192 > > > > > > Why not s/type/type_/ here? I think I was following the guideline of

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 22, 2015, 8:42 p.m.) Review request for mesos and Benjamin

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 22, 2015, 8:49 p.m.) Review request for mesos and Benjamin

Re: Review Request 41593: stout: Added `jsonify` function.

> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, line 167 > > > > > > Is the `int32_t`, `uint32_t`, and `float` overloads necessary? With only

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 22, 2015, 8:43 p.m.) Review request for mesos and Benjamin

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 23, 2015, 3:56 a.m.) Review request for mesos and Benjamin

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/ --- (Updated Dec. 22, 2015, 8:23 p.m.) Review request for mesos and Benjamin

Re: Review Request 41593: stout: Added `jsonify` function.

> On Dec. 22, 2015, 4:52 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp, lines 58-63 > > > > > > An implicit cast operator that is non-const is always code smell > >

Re: Review Request 41593: stout: Added `jsonify` function.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41593/#review111438 --- 3rdparty/libprocess/3rdparty/stout/include/stout/jsonify.hpp