Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-02-20 Thread Yongqiao Wang
> On Feb. 19, 2016, 9:36 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1068-1070 > > > > > > Why don't we need to set `rebalance` here? > > Yongqiao Wang wrote: >

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-02-19 Thread Alexander Rukletsov
> On Feb. 19, 2016, 9:36 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1068-1070 > > > > > > Why don't we need to set `rebalance` here? > > Yongqiao Wang wrote: >

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-02-19 Thread Yongqiao Wang
> On Feb. 19, 2016, 9:36 a.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1068-1070 > > > > > > Why don't we need to set `rebalance` here? According to my understanding, A

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-02-19 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review119848 --- src/master/allocator/mesos/hierarchical.cpp (lines 1068 - 1070)

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-02-14 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Feb. 14, 2016, 11:37 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-25 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 25, 2016, 3:06 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-19 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review115349 --- Ship it! Looks great. Just a couple of nits after your recent

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-19 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 20, 2016, 6:21 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-18 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 18, 2016, 8:20 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-18 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 18, 2016, 8:32 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-18 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 18, 2016, 8:33 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-18 Thread Yongqiao Wang
> On Jan. 6, 2016, 10:09 a.m., Adam B wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1048-1051 > > > > > > Does anything rely on this behavior of erasing 1.0s from the hashmap? I > > know it'll

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-18 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 18, 2016, 8:53 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-15 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 15, 2016, 10:46 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-15 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 15, 2016, 8:50 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-15 Thread Adam B
> On Jan. 6, 2016, 2:09 a.m., Adam B wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1048-1051 > > > > > > Does anything rely on this behavior of erasing 1.0s from the hashmap? I > > know it'll

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-15 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review114683 --- Ship it! You fix these last couple issues; Let me wrap up

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-12 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 12, 2016, 9:34 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 12, 2016, 4:04 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 12, 2016, 7:29 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 11, 2016, 11:31 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-11 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 11, 2016, 2:48 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-09 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 9, 2016, 11:36 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 8, 2016, 12:40 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-06 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 6, 2016, 11:01 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-06 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review113035 --- Nearly flawless, but I want to wait until I've gotten through a

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-06 Thread Yongqiao Wang
> On Jan. 6, 2016, 10:09 a.m., Adam B wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1048-1051 > > > > > > Does anything rely on this behavior of erasing 1.0s from the hashmap? I > > know it'll

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-05 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 5, 2016, 11:38 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-05 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 5, 2016, 12:50 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-05 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 5, 2016, 12:54 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-05 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 6, 2016, 1:53 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-05 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 6, 2016, 2:06 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-05 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 6, 2016, 2:14 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 4, 2016, 11:55 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2016-01-04 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review112528 --- Looks good. Nice, simple, and clean. Just a few suggestions, and

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 4, 2016, 11:21 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2016-01-04 Thread Yongqiao Wang
> On Jan. 4, 2016, 10:23 a.m., Adam B wrote: > > include/mesos/mesos.proto, lines 1676-1678 > > > > > > Do we really need this message? Can't we just use `repeated WeightInfo > > weightInfos` in any other

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 4, 2016, 8:27 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-04 Thread Adam B
> On Jan. 4, 2016, 2:23 a.m., Adam B wrote: > > include/mesos/mesos.proto, line 1669 > > > > > > Let's make it `optional`, in case we later want to add weights per > > principal, frameworkId, etc. Experienced

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 4, 2016, 1:52 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 4, 2016, 1:44 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 5, 2016, 5:27 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 5, 2016, 5:45 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights.

2016-01-04 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Jan. 5, 2016, 7:23 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-31 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 31, 2015, 12:07 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-31 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 31, 2015, 11:53 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-30 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 30, 2015, 8:07 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-30 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 30, 2015, 11:54 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-30 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 30, 2015, 8:32 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-29 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 30, 2015, 2:32 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-29 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 29, 2015, 8:59 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-29 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 29, 2015, 9:02 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-29 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 29, 2015, 9:52 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-29 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 29, 2015, 12:49 p.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-28 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 29, 2015, 6:38 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-28 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 29, 2015, 7:03 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-28 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 29, 2015, 7:20 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-25 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 26, 2015, 2:20 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review111818 --- src/master/allocator/mesos/hierarchical.cpp (line 1055)

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 24, 2015, 2:46 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 24, 2015, 2:41 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review111824 --- Ship it! Ship It! - Qian Zhang On Dec. 24, 2015, 10:46 a.m.,

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 23, 2015, 9:05 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 23, 2015, 9:18 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Yongqiao Wang
> On Dec. 23, 2015, 8:22 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1057 > > > > > > Do we support updating weight for an inactive role? If yes, I think > > this `CHECK` will

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-23 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review111749 --- src/master/allocator/mesos/hierarchical.cpp (line 1051)

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-22 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 23, 2015, 5:46 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review111447 --- Patch looks great! Reviews applied: [41597] Passed command:

Re: Review Request 41597: Extending allocator interface to support dynamic weights

2015-12-20 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/ --- (Updated Dec. 21, 2015, 6:39 a.m.) Review request for mesos, Adam B and Qian