Re: Review Request 41613: Added `defaultRole` constant to persistent volume tests.

2016-01-04 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/#review112746
---


The summary needs to be updated to reflect your update "DEFAULT_ROLE" but not 
"defaultRole"

- Guangya Liu


On 一月 4, 2016, 4:32 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41613/
> ---
> 
> (Updated 一月 4, 2016, 4:32 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `defaultRole` constant to persistent volume tests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 2fb57814b2805bc76981d1877603a1a033f29289 
> 
> Diff: https://reviews.apache.org/r/41613/diff/
> 
> 
> Testing
> ---
> 
> `GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 41613: Added `defaultRole` constant to persistent volume tests.

2016-01-04 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/
---

(Updated Jan. 4, 2016, 4:32 p.m.)


Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.


Changes
---

Addressed comment.


Repository: mesos


Description
---

Added `defaultRole` constant to persistent volume tests.


Diffs (updated)
-

  src/tests/persistent_volume_tests.cpp 
2fb57814b2805bc76981d1877603a1a033f29289 

Diff: https://reviews.apache.org/r/41613/diff/


Testing
---

`GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`


Thanks,

Greg Mann



Re: Review Request 41613: Added `defaultRole` constant to persistent volume tests.

2015-12-22 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/#review111589
---

Ship it!



src/tests/persistent_volume_tests.cpp (line 68)


Usually, we capitalize constants, so how about `DEFAULT_ROLE`?



src/tests/persistent_volume_tests.cpp (lines 682 - 684)


I always find increasing line numbers unfortunate : ). What do you think 
about the following formatting:
```
  Resources taskResources = Resources::parse(
  "cpus:1;mem:128;disk(" + defaultRole + "):32").get() + volume;
```


- Alexander Rukletsov


On Dec. 21, 2015, 7:12 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41613/
> ---
> 
> (Updated Dec. 21, 2015, 7:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `defaultRole` constant to persistent volume tests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 2fb57814b2805bc76981d1877603a1a033f29289 
> 
> Diff: https://reviews.apache.org/r/41613/diff/
> 
> 
> Testing
> ---
> 
> `GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Review Request 41613: Added `defaultRole` constant to persistent volume tests.

2015-12-21 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/
---

Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.


Repository: mesos


Description
---

Added `defaultRole` constant to persistent volume tests.


Diffs
-

  src/tests/persistent_volume_tests.cpp 
2fb57814b2805bc76981d1877603a1a033f29289 

Diff: https://reviews.apache.org/r/41613/diff/


Testing
---

`GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`


Thanks,

Greg Mann



Re: Review Request 41613: Added `defaultRole` constant to persistent volume tests.

2015-12-21 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41613/#review111553
---


Patch looks great!

Reviews applied: [41613]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 21, 2015, 7:12 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41613/
> ---
> 
> (Updated Dec. 21, 2015, 7:12 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Jie Yu, and Michael Park.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added `defaultRole` constant to persistent volume tests.
> 
> 
> Diffs
> -
> 
>   src/tests/persistent_volume_tests.cpp 
> 2fb57814b2805bc76981d1877603a1a033f29289 
> 
> Diff: https://reviews.apache.org/r/41613/diff/
> 
> 
> Testing
> ---
> 
> `GTEST_FILTER="PersistentVolumeTest*" bin/mesos-tests.sh`
> 
> 
> Thanks,
> 
> Greg Mann
> 
>