Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Jan. 12, 2016, 9:35 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41672: Test case(s) for weights + allocation behavior

> On Jan. 11, 2016, 10:13 a.m., Adam B wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2218-2219 > > > > > > Why hardcode 3? I'd think you could just run a while loop and actually > > assert the size

Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review113990 --- Bad patch! Reviews applied: [41597, 41672] Failed command:

Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review113711 --- Looking good. Just some minor suggestions here and there.

Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review113789 --- Bad patch! Reviews applied: [41597, 41672] Failed command:

Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review111930 --- Overall comments: I think we can make the test a bit more concise

Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Dec. 30, 2015, 2:33 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review112281 --- Patch looks great! Reviews applied: [41597, 41672] Passed

Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review112134 --- Patch looks great! Reviews applied: [41597, 41672] Passed

Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Dec. 29, 2015, 7:21 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Dec. 23, 2015, 9:44 a.m.) Review request for mesos, Adam B and Neil

Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Dec. 24, 2015, 2:49 a.m.) Review request for mesos, Adam B, Neil

Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/#review111819 --- Patch looks great! Reviews applied: [41597, 41672] Passed

Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- Review request for mesos, Adam B and Neil Conway. Bugs: MESOS-4200

Re: Review Request 41672: Test case(s) for weights + allocation behavior

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41672/ --- (Updated Dec. 23, 2015, 5:49 a.m.) Review request for mesos, Adam B and Neil