Re: Review Request 41675: Speed up SlaveTest.HTTPSchedulerSlaveRestart

2015-12-29 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41675/#review112237
---

Ship it!


Ship It!

- Timothy Chen


On Dec. 29, 2015, 1:48 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41675/
> ---
> 
> (Updated Dec. 29, 2015, 1:48 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Anand Mazumdar.
> 
> 
> Bugs: MESOS-4163
> https://issues.apache.org/jira/browse/MESOS-4163
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We should advance a reregister timeout to speed up the slave registration.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 
> 
> Diff: https://reviews.apache.org/r/41675/diff/
> 
> 
> Testing
> ---
> 
> make check -j4 GTEST_FILTER=SlaveTest.HTTPSchedulerSlaveRestart
> 
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from SlaveTest
> [ RUN  ] SlaveTest.HTTPSchedulerSlaveRestart
> I1229 09:38:10.183754 2138071808 exec.cpp:134] Version: 0.27.0
> I1229 09:38:10.188813 328146944 exec.cpp:208] Executor registered on slave 
> 97a7a987-6edb-4ee1-a79f-4de08bc0af10-S0
> Registered executor on 9.110.49.60
> Starting task 4f4f7ebe-625c-42eb-aaa8-d569333751e8
> sh -c 'sleep 1000'
> Forked command at 31243
> I1229 09:38:10.212271 329220096 exec.cpp:254] Received reconnect request from 
> slave 97a7a987-6edb-4ee1-a79f-4de08bc0af10-S0
> I1229 09:38:10.212829 327610368 exec.cpp:231] Executor re-registered on slave 
> 97a7a987-6edb-4ee1-a79f-4de08bc0af10-S0
> Re-registered executor on 9.110.49.60
> [   OK ] SlaveTest.HTTPSchedulerSlaveRestart (417 ms)
> [--] 1 test from SlaveTest (417 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (426 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>



Review Request 41675: Speed up SlaveTest.HTTPSchedulerSlaveRestart

2015-12-28 Thread Jian Qiu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41675/
---

Review request for mesos and Alexander Rukletsov.


Bugs: MESOS-4163
https://issues.apache.org/jira/browse/MESOS-4163


Repository: mesos


Description
---

We should advance a reregister timeout to speed up the slave registration.


Diffs
-

  src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 

Diff: https://reviews.apache.org/r/41675/diff/


Testing
---

make check -j4 GTEST_FILTER=SlaveTest.HTTPSchedulerSlaveRestart

[==] Running 1 test from 1 test case.
[--] Global test environment set-up.
[--] 1 test from SlaveTest
[ RUN  ] SlaveTest.HTTPSchedulerSlaveRestart
I1229 09:38:10.183754 2138071808 exec.cpp:134] Version: 0.27.0
I1229 09:38:10.188813 328146944 exec.cpp:208] Executor registered on slave 
97a7a987-6edb-4ee1-a79f-4de08bc0af10-S0
Registered executor on 9.110.49.60
Starting task 4f4f7ebe-625c-42eb-aaa8-d569333751e8
sh -c 'sleep 1000'
Forked command at 31243
I1229 09:38:10.212271 329220096 exec.cpp:254] Received reconnect request from 
slave 97a7a987-6edb-4ee1-a79f-4de08bc0af10-S0
I1229 09:38:10.212829 327610368 exec.cpp:231] Executor re-registered on slave 
97a7a987-6edb-4ee1-a79f-4de08bc0af10-S0
Re-registered executor on 9.110.49.60
[   OK ] SlaveTest.HTTPSchedulerSlaveRestart (417 ms)
[--] 1 test from SlaveTest (417 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (426 ms total)
[  PASSED  ] 1 test.


Thanks,

Jian Qiu



Re: Review Request 41675: Speed up SlaveTest.HTTPSchedulerSlaveRestart

2015-12-28 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41675/#review112113
---


Patch looks great!

Reviews applied: [41675]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 29, 2015, 1:48 a.m., Jian Qiu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41675/
> ---
> 
> (Updated Dec. 29, 2015, 1:48 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Anand Mazumdar.
> 
> 
> Bugs: MESOS-4163
> https://issues.apache.org/jira/browse/MESOS-4163
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> We should advance a reregister timeout to speed up the slave registration.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 
> 
> Diff: https://reviews.apache.org/r/41675/diff/
> 
> 
> Testing
> ---
> 
> make check -j4 GTEST_FILTER=SlaveTest.HTTPSchedulerSlaveRestart
> 
> [==] Running 1 test from 1 test case.
> [--] Global test environment set-up.
> [--] 1 test from SlaveTest
> [ RUN  ] SlaveTest.HTTPSchedulerSlaveRestart
> I1229 09:38:10.183754 2138071808 exec.cpp:134] Version: 0.27.0
> I1229 09:38:10.188813 328146944 exec.cpp:208] Executor registered on slave 
> 97a7a987-6edb-4ee1-a79f-4de08bc0af10-S0
> Registered executor on 9.110.49.60
> Starting task 4f4f7ebe-625c-42eb-aaa8-d569333751e8
> sh -c 'sleep 1000'
> Forked command at 31243
> I1229 09:38:10.212271 329220096 exec.cpp:254] Received reconnect request from 
> slave 97a7a987-6edb-4ee1-a79f-4de08bc0af10-S0
> I1229 09:38:10.212829 327610368 exec.cpp:231] Executor re-registered on slave 
> 97a7a987-6edb-4ee1-a79f-4de08bc0af10-S0
> Re-registered executor on 9.110.49.60
> [   OK ] SlaveTest.HTTPSchedulerSlaveRestart (417 ms)
> [--] 1 test from SlaveTest (417 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (426 ms total)
> [  PASSED  ] 1 test.
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>