Re: Review Request 41715: Support parsing url in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41715/#review112328 --- Ship it! 3rdparty/libprocess/src/http.cpp (line 169)

Re: Review Request 41715: Support parsing url in libprocess.

> On Dec. 28, 2015, 8:02 p.m., Jojy Varghese wrote: > > 3rdparty/libprocess/src/http.cpp, line 183 > > > > > > Have we considered using a regex parser for doing this? C++11 regex > > support is added since gcc 4.9

Re: Review Request 41715: Support parsing url in libprocess.

> On Dec. 27, 2015, 2:56 a.m., Jojy Varghese wrote: > > 3rdparty/libprocess/src/http.cpp, line 182 > > > > > > I would add some comments through the function to explain each > > sub-section's intent. We usually

Re: Review Request 41715: Support parsing url in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41715/#review112061 --- 3rdparty/libprocess/src/http.cpp (line 183)

Re: Review Request 41715: Support parsing url in libprocess.

> On Dec. 27, 2015, 2:56 a.m., Jojy Varghese wrote: > > 3rdparty/libprocess/src/http.cpp, line 190 > > > > > > Can we avoid using magic numbers ('3' here)? It's paired with the magic string '://' :) I'm not sure

Re: Review Request 41715: Support parsing url in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41715/ --- (Updated Dec. 28, 2015, 8:23 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 41715: Support parsing url in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41715/ --- (Updated Dec. 26, 2015, 8:24 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 41715: Support parsing url in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41715/#review111918 --- 3rdparty/libprocess/src/http.cpp (line 182)

Re: Review Request 41715: Support parsing url in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41715/#review111887 --- Patch looks great! Reviews applied: [41715] Passed command:

Review Request 41715: Support parsing url in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41715/ --- Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese. Repository:

Re: Review Request 41715: Support parsing url in libprocess.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41715/#review111903 --- Ship it! Verified that the parse method handles some conner cases