Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-02-25 Thread Alex Rukletsov
Folks, Sorry for not communicating it properly, I should have discarded the patch actually. As Ben already mentioned, we had agreed to rework it and maybe split into multiple patches for clarity. However, I haven't published them yet. Best, Alex On 23 Feb 2016 18:35, "Bernd Mathiske"

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-02-23 Thread Bernd Mathiske
> On Feb. 23, 2016, 9:33 a.m., Ben Mahler wrote: > > Apologies, did you check with Alex prior to committing? We talked about > > this change recently but we didn't publish the comments, sorry that it > > wasn't clear! I reverted it for now, since we didn't really like the empty > > map

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-02-23 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review120338 --- Apologies, did you check with Alex prior to committing? We talked

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-02-15 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review119268 --- Ship it! Ship It! - Klaus Ma On Jan. 28, 2016, 9:12 p.m.,

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/ --- (Updated Jan. 28, 2016, 1:12 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/ --- (Updated Jan. 22, 2016, 10:51 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review115781 --- Bad patch! Reviews applied: [41950] Failed command:

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/ --- (Updated Jan. 22, 2016, 1:20 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-20 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review115382 --- Ship it! Ship It! - Bernd Mathiske On Jan. 12, 2016, 1:34

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review114937 --- Patch looks great! Reviews applied: [41936, 41937, 41947, 41948,

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review114931 --- Ship it! Ship It! - Guangya Liu On 一月 12, 2016, 9:34 p.m.,

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-12 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review113989 --- src/tests/hierarchical_allocator_tests.cpp (line 223)

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/ --- (Updated Jan. 12, 2016, 9:34 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/#review114003 --- Bad patch! Reviews applied: [41936] Failed command:

Review Request 41950: Cleaned up hierarchical allocator tests.

2016-01-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41950/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.