Re: Review Request 41959: Statically initializing fetcher plugins.

2016-07-09 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41959/#review141533 --- Closing this review due to inactivity. Please see our

Re: Review Request 41959: Statically initializing fetcher plugins.

2016-01-25 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41959/#review116115 --- I am wondering if you do see performance issue regarding this? We

Re: Review Request 41959: Statically initializing fetcher plugins.

2016-01-25 Thread Jojy Varghese
> On Jan. 25, 2016, 5:12 p.m., Jie Yu wrote: > > I am wondering if you do see performance issue regarding this? We typically > > don't optimize the code too much until it becomes a problem. Also, we try > > to avoid global variable dependencies (i.e., static bool isCreateError in > > this

Re: Review Request 41959: Statically initializing fetcher plugins.

2016-01-25 Thread Jie Yu
> On Jan. 25, 2016, 5:12 p.m., Jie Yu wrote: > > I am wondering if you do see performance issue regarding this? We typically > > don't optimize the code too much until it becomes a problem. Also, we try > > to avoid global variable dependencies (i.e., static bool isCreateError in > > this

Re: Review Request 41959: Statically initializing fetcher plugins.

2016-01-25 Thread Jie Yu
> On Jan. 25, 2016, 5:12 p.m., Jie Yu wrote: > > I am wondering if you do see performance issue regarding this? We typically > > don't optimize the code too much until it becomes a problem. Also, we try > > to avoid global variable dependencies (i.e., static bool isCreateError in > > this

Re: Review Request 41959: Statically initializing fetcher plugins.

2016-01-25 Thread Jojy Varghese
> On Jan. 25, 2016, 5:12 p.m., Jie Yu wrote: > > I am wondering if you do see performance issue regarding this? We typically > > don't optimize the code too much until it becomes a problem. Also, we try > > to avoid global variable dependencies (i.e., static bool isCreateError in > > this

Re: Review Request 41959: Statically initializing fetcher plugins.

2016-01-25 Thread Jojy Varghese
> On Jan. 25, 2016, 5:12 p.m., Jie Yu wrote: > > I am wondering if you do see performance issue regarding this? We typically > > don't optimize the code too much until it becomes a problem. Also, we try > > to avoid global variable dependencies (i.e., static bool isCreateError in > > this

Re: Review Request 41959: Statically initializing fetcher plugins.

2016-01-25 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41959/ --- (Updated Jan. 25, 2016, 9:19 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 41959: Statically initializing fetcher plugins.

2016-01-25 Thread Jojy Varghese
> On Jan. 25, 2016, 5:12 p.m., Jie Yu wrote: > > I am wondering if you do see performance issue regarding this? We typically > > don't optimize the code too much until it becomes a problem. Also, we try > > to avoid global variable dependencies (i.e., static bool isCreateError in > > this

Re: Review Request 41959: Statically initializing fetcher plugins.

2016-01-13 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41959/ --- (Updated Jan. 13, 2016, 11:08 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 41959: Statically initializing fetcher plugins.

2016-01-11 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41959/ --- (Updated Jan. 12, 2016, 12:42 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 41959: Statically initializing fetcher plugins.

2016-01-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41959/#review113036 --- Patch looks great! Reviews applied: [41958, 41959] Passed

Review Request 41959: Statically initializing fetcher plugins.

2016-01-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41959/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 41959: Statically initializing fetcher plugins.

2016-01-05 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41959/ --- (Updated Jan. 6, 2016, 2:14 a.m.) Review request for mesos and Jie Yu.