Re: Review Request 42016: Windows:[2/2] Use ZK in Windows build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/ --- (Updated Jan. 29, 2016, 2:17 a.m.) Review request for Alex Naparu, Daniel Pravat, Alex Clemmer, M Lawindi, and Yi Sun. Bugs: MESOS-4497 https://issues.apache.org/jira/browse/MESOS-4497 Repository: mesos Description --- Windows:[2/2] Use ZK in Windows build. Diffs - 3rdparty/CMakeLists.txt ac5c25a8797a687e84384682975ab99fb3e30448 3rdparty/cmake/Mesos3rdpartyConfigure.cmake 34e61ff90eca0ffdddb6b6b8e2f8e552691637fa 3rdparty/patch.exe.manifest PRE-CREATION CMakeLists.txt 9b7044b7860fd64b854ac27b28a48d297dfdeae8 src/slave/cmake/SlaveConfigure.cmake cf378a27297474b2a9f338e0c832612370f7302a Diff: https://reviews.apache.org/r/42016/diff/ Testing --- Thanks, M Lawindi
Re: Review Request 42016: Windows:[2/2] Use ZK in Windows build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/ --- (Updated Jan. 27, 2016, 10:29 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Alex Clemmer, M Lawindi, and Yi Sun. Summary (updated) - Windows:[2/2] Use ZK in Windows build. Repository: mesos Description (updated) --- Windows:[2/2] Use ZK in Windows build. Diffs (updated) - 3rdparty/CMakeLists.txt ac5c25a8797a687e84384682975ab99fb3e30448 3rdparty/cmake/Mesos3rdpartyConfigure.cmake 34e61ff90eca0ffdddb6b6b8e2f8e552691637fa 3rdparty/patch.exe.manifest PRE-CREATION CMakeLists.txt 9b7044b7860fd64b854ac27b28a48d297dfdeae8 src/slave/cmake/SlaveConfigure.cmake cf378a27297474b2a9f338e0c832612370f7302a Diff: https://reviews.apache.org/r/42016/diff/ Testing --- Thanks, M Lawindi
Re: Review Request 42016: Windows:[2/2] Use ZK in Windows build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/#review116676 --- Patch looks great! Reviews applied: [39850, 39851, 39852, 39888, 39889, 40102, 40851, 42016] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 27, 2016, 10:29 p.m., M Lawindi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42016/ > --- > > (Updated Jan. 27, 2016, 10:29 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Alex Clemmer, M > Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows:[2/2] Use ZK in Windows build. > > > Diffs > - > > 3rdparty/CMakeLists.txt ac5c25a8797a687e84384682975ab99fb3e30448 > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > 34e61ff90eca0ffdddb6b6b8e2f8e552691637fa > 3rdparty/patch.exe.manifest PRE-CREATION > CMakeLists.txt 9b7044b7860fd64b854ac27b28a48d297dfdeae8 > src/slave/cmake/SlaveConfigure.cmake > cf378a27297474b2a9f338e0c832612370f7302a > > Diff: https://reviews.apache.org/r/42016/diff/ > > > Testing > --- > > > Thanks, > > M Lawindi > >
Re: Review Request 42016: Windows:[2/2] Use ZK in Windows build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/ --- (Updated Jan. 28, 2016, 4:58 a.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Alex Clemmer, M Lawindi, and Yi Sun. Repository: mesos Description --- Windows:[2/2] Use ZK in Windows build. Diffs (updated) - 3rdparty/CMakeLists.txt ac5c25a8797a687e84384682975ab99fb3e30448 3rdparty/cmake/Mesos3rdpartyConfigure.cmake 34e61ff90eca0ffdddb6b6b8e2f8e552691637fa 3rdparty/patch.exe.manifest PRE-CREATION CMakeLists.txt 9b7044b7860fd64b854ac27b28a48d297dfdeae8 src/slave/cmake/SlaveConfigure.cmake cf378a27297474b2a9f338e0c832612370f7302a Diff: https://reviews.apache.org/r/42016/diff/ Testing --- Thanks, M Lawindi
Re: Review Request 42016: Windows:[2/2] Use ZK in Windows build.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42016/#review116640 --- Ship it! Ship It! - Alex Clemmer On Jan. 27, 2016, 10:29 p.m., M Lawindi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42016/ > --- > > (Updated Jan. 27, 2016, 10:29 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Alex Clemmer, M > Lawindi, and Yi Sun. > > > Repository: mesos > > > Description > --- > > Windows:[2/2] Use ZK in Windows build. > > > Diffs > - > > 3rdparty/CMakeLists.txt ac5c25a8797a687e84384682975ab99fb3e30448 > 3rdparty/cmake/Mesos3rdpartyConfigure.cmake > 34e61ff90eca0ffdddb6b6b8e2f8e552691637fa > 3rdparty/patch.exe.manifest PRE-CREATION > CMakeLists.txt 9b7044b7860fd64b854ac27b28a48d297dfdeae8 > src/slave/cmake/SlaveConfigure.cmake > cf378a27297474b2a9f338e0c832612370f7302a > > Diff: https://reviews.apache.org/r/42016/diff/ > > > Testing > --- > > > Thanks, > > M Lawindi > >
