Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

2016-01-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42123/ --- (Updated 一月 23, 2016, 6:08 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

2016-01-16 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42123/ --- (Updated 一月 16, 2016, 8 a.m.) Review request for mesos, Ben Mahler, Artem Harut

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

2016-01-11 Thread Klaus Ma
> On Jan. 11, 2016, 11:33 a.m., Klaus Ma wrote: > > Would you add test case for that? It seems `make check` will also pass > > without this patch :). > > Guangya Liu wrote: > I think that we need to update oversubscription_tests.cpp to use > usageSlack() instead of revocable() to get usage

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

2016-01-10 Thread Guangya Liu
> On 一月 11, 2016, 3:33 a.m., Klaus Ma wrote: > > Would you add test case for that? It seems `make check` will also pass > > without this patch :). > > Guangya Liu wrote: > I think that we need to update oversubscription_tests.cpp to use > usageSlack() instead of revocable() to get usage sl

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

2016-01-10 Thread Klaus Ma
> On Jan. 11, 2016, 11:33 a.m., Klaus Ma wrote: > > Would you add test case for that? It seems `make check` will also pass > > without this patch :). > > Guangya Liu wrote: > I think that we need to update oversubscription_tests.cpp to use > usageSlack() instead of revocable() to get usage

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

2016-01-10 Thread Guangya Liu
> On 一月 11, 2016, 3:33 a.m., Klaus Ma wrote: > > Would you add test case for that? It seems `make check` will also pass > > without this patch :). I think that we need to update oversubscription_tests.cpp to use usageSlack() instead of revocable() to get usage slack resources which is more acc

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

2016-01-10 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42123/#review113670 --- Would you add test case for that? It seems `make check` will also p

Re: Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

2016-01-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42123/ --- (Updated 一月 11, 2016, 1:56 a.m.) Review request for mesos, Ben Mahler, Artem Ha

Review Request 42123: Enabled load qos controller use USAGE SLACK revocable resources.

2016-01-10 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42123/ --- Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van Remoortere, J