Re: Review Request 42222: Added a comment on allocator recovery.

2016-02-02 Thread Alexander Rukletsov
> On Jan. 15, 2016, 6:50 a.m., Ben Mahler wrote: > > Thanks Alex! I ended up going over the structure of the recover code and > > left some higher level comments. There also appears to be a bug that will > > crash the master that I marked as an issue :) > > > > Have we convinced ourselves

Re: Review Request 42222: Added a comment on allocator recovery.

2016-01-17 Thread Alexander Rukletsov
> On Jan. 15, 2016, 6:50 a.m., Ben Mahler wrote: > > Thanks Alex! I ended up going over the structure of the recover code and > > left some higher level comments. There also appears to be a bug that will > > crash the master that I marked as an issue :) > > > > Have we convinced ourselves

Re: Review Request 42222: Added a comment on allocator recovery.

2016-01-16 Thread Joris Van Remoortere
> On Jan. 15, 2016, 6:50 a.m., Ben Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 205-206 > > > > > > It looks like if we trip the `resume` call in `addSlave`, this delayed > > resume will

Re: Review Request 42222: Added a comment on allocator recovery.

2016-01-16 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review114888 --- Ship it! I've rephrased and moved the comment as per BenM's

Re: Review Request 42222: Added a comment on allocator recovery.

2016-01-14 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review114628 --- Thanks Alex! I ended up going over the structure of the recover

Re: Review Request 42222: Added a comment on allocator recovery.

2016-01-13 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review114161 --- Patch looks great! Reviews applied: [42221, 4] Passed

Re: Review Request 42222: Added a comment on allocator recovery.

2016-01-13 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review114218 --- Ship it! Ship It! - Klaus Ma On Jan. 13, 2016, 7:06 a.m.,

Review Request 42222: Added a comment on allocator recovery.

2016-01-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/ --- Review request for mesos, Ben Mahler and Joris Van Remoortere. Repository:

Re: Review Request 42222: Added a comment on allocator recovery.

2016-01-12 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4/#review114125 --- Ship it! Ship It! - Guangya Liu On 一月 12, 2016, 11:06 p.m.,