Re: Review Request 42476: Introduced protobuf for set quota requests.

> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote: > > include/mesos/quota/quota.proto, line 56 > > > > > > I feel that optimizing here (with = 16) is more confusing than helpful, > > especially as this protobuf is

Re: Review Request 42476: Introduced protobuf for set quota requests.

> On Jan. 25, 2016, 8:40 a.m., Joris Van Remoortere wrote: > > include/mesos/quota/quota.proto, line 56 > > > > > > I don't get the `16` as per Joerg's comment. Commented on above. > On Jan. 25, 2016, 8:40 a.m.,

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/ --- (Updated Jan. 26, 2016, 4:33 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/#review116400 --- Patch looks great! Reviews applied: [42477, 42476] Passed

Re: Review Request 42476: Introduced protobuf for set quota requests.

> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote: > > include/mesos/quota/quota.proto, line 56 > > > > > > I feel that optimizing here (with = 16) is more confusing than helpful, > > especially as this protobuf is

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/ --- (Updated Jan. 26, 2016, 8:48 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/#review116482 --- Fix it, then Ship it! src/master/quota.cpp (lines 94 - 95)

Re: Review Request 42476: Introduced protobuf for set quota requests.

> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote: > > include/mesos/quota/quota.proto, line 56 > > > > > > I feel that optimizing here (with = 16) is more confusing than helpful, > > especially as this protobuf is

Re: Review Request 42476: Introduced protobuf for set quota requests.

> On Jan. 23, 2016, 5:27 a.m., Klaus Ma wrote: > > src/master/quota_handler.cpp, line 77 > > > > > > Do we need to check `has_role()`? It will just be an empty role if it was not set. - Joris

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/#review116062 --- Fix it, then Ship it! include/mesos/quota/quota.proto (line

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/#review115929 --- Patch looks great! Reviews applied: [42477, 42476] Passed

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/#review115623 --- Ship it! After addressing Joerg's remaining issues, ship it! -

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/#review115387 --- docs/quota.md (line 94)

Re: Review Request 42476: Introduced protobuf for set quota requests.

> On Jan. 20, 2016, 9:14 a.m., Bernd Mathiske wrote: > > docs/quota.md, line 94 > > > > > > plural I think we use single everywhere. It means total quota guarantee and shouldn't necessarily resemble the fact that

Re: Review Request 42476: Introduced protobuf for set quota requests.

> On Jan. 20, 2016, 1:14 a.m., Bernd Mathiske wrote: > > docs/quota.md, line 94 > > > > > > plural > > Alexander Rukletsov wrote: > I think we use single everywhere. It means total quota guarantee and >

Re: Review Request 42476: Introduced protobuf for set quota requests.

> On Jan. 20, 2016, 9:14 a.m., Bernd Mathiske wrote: > > docs/quota.md, line 94 > > > > > > plural > > Alexander Rukletsov wrote: > I think we use single everywhere. It means total quota guarantee and >

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/ --- (Updated Jan. 20, 2016, 12:12 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/#review115127 --- Ship it! include/mesos/quota/quota.proto (line 53)

Re: Review Request 42476: Introduced protobuf for set quota requests.

> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote: > > src/master/quota_handler.cpp, line 280 > > > > > > Not an issue, but question/remark: the protoRequest.error() is most > > likely to be less concise compared to

Re: Review Request 42476: Introduced protobuf for set quota requests.

> On Jan. 19, 2016, 8:37 a.m., Joerg Schad wrote: > > include/mesos/quota/quota.proto, line 54 > > > > > > Given the naming scheme QuotaStatus wouldn't a more consistent name be > > QuotaSet? > > Alexander

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/ --- (Updated Jan. 19, 2016, 3:06 p.m.) Review request for mesos, Ben Mahler, Joerg

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/ --- (Updated Jan. 18, 2016, 11:37 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/#review115092 --- Patch looks great! Reviews applied: [42477, 42476] Passed

Review Request 42476: Introduced protobuf for set quota requests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42476/ --- Review request for mesos, Ben Mahler, Joerg Schad, and Joris Van Remoortere.