Re: Review Request 42586: Defined the NetClsHandleManager class.

2016-02-03 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/ --- (Updated Feb. 3, 2016, 8:43 p.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 42586: Defined the NetClsHandleManager class.

2016-02-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/#review117633 --- Looks good. Some minor comments modulo Jie's earlier comments.

Re: Review Request 42586: Defined the NetClsHandleManager class.

2016-02-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/#review117629 --- Fix it, then Ship it!

Re: Review Request 42586: Defined the NetClsHandleManager class.

2016-02-02 Thread Avinash sridharan
> On Feb. 1, 2016, 5:49 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.hpp, lines 51-52 > > > > > > `s/majHandle/_major/` > > `s/minHandle/_minor/` > > > > Also, remove

Re: Review Request 42586: Defined the NetClsHandleManager class.

2016-02-02 Thread Avinash sridharan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42586/ --- (Updated Feb. 3, 2016, 6:44 a.m.) Review request for mesos and Jie Yu.