Re: Review Request 42629: Added tests for offer filters.

2016-01-22 Thread Alexander Rukletsov
> On Jan. 22, 2016, 8:29 a.m., Ben Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 509-515 > > > > > > Looks like you only need the second advance here? Technically, you are > > triggering two ba

Re: Review Request 42629: Added tests for offer filters.

2016-01-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42629/#review115801 --- Ship it! Great tests, thanks! I made some tweaks based on the sugg

Review Request 42629: Added tests for offer filters.

2016-01-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42629/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4302 https://issues.ap