Re: Review Request 42689: Clarified a comment that occurs in several test cases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42689/#review118432 --- Patch looks great! Reviews applied: [42689] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Feb. 9, 2016, 5:13 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42689/ > --- > > (Updated Feb. 9, 2016, 5:13 p.m.) > > > Review request for mesos and Adam B. > > > Repository: mesos > > > Description > --- > > Clarified a comment that occurs in several test cases. > > > Diffs > - > > src/tests/containerizer/filesystem_isolator_tests.cpp > bec4966daeb756c3217f52907d36991889b923ce > src/tests/persistent_volume_tests.cpp > cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0 > src/tests/reservation_endpoints_tests.cpp > 35c093567b07a11ca6eee85e2ff91894a460a7af > > Diff: https://reviews.apache.org/r/42689/diff/ > > > Testing > --- > > Seems like these snuck in due to copy-and-pastes that were concurrent with > the patch to fixup the rest of the instances of this comment. > > > Thanks, > > Neil Conway > >
Re: Review Request 42689: Clarified a comment that occurs in several test cases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42689/#review118540 --- Ship it! Ship It! - Adam B On Feb. 9, 2016, 9:13 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42689/ > --- > > (Updated Feb. 9, 2016, 9:13 a.m.) > > > Review request for mesos and Adam B. > > > Repository: mesos > > > Description > --- > > Clarified a comment that occurs in several test cases. > > > Diffs > - > > src/tests/containerizer/filesystem_isolator_tests.cpp > bec4966daeb756c3217f52907d36991889b923ce > src/tests/persistent_volume_tests.cpp > cbf2bcedd5b4c14107d3b50a74f161aa9395d7d0 > src/tests/reservation_endpoints_tests.cpp > 35c093567b07a11ca6eee85e2ff91894a460a7af > > Diff: https://reviews.apache.org/r/42689/diff/ > > > Testing > --- > > Seems like these snuck in due to copy-and-pastes that were concurrent with > the patch to fixup the rest of the instances of this comment. > > > Thanks, > > Neil Conway > >
Re: Review Request 42689: Clarified a comment that occurs in several test cases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42689/#review118360 --- Looks good, but the patch doesn't apply cleanly anymore with `apply-reviews.py`. If you rebase it, I'll commit it. - Adam B On Jan. 23, 2016, 3:05 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42689/ > --- > > (Updated Jan. 23, 2016, 3:05 p.m.) > > > Review request for mesos and Adam B. > > > Repository: mesos > > > Description > --- > > Clarified a comment that occurs in several test cases. > > > Diffs > - > > src/tests/persistent_volume_tests.cpp > 7acf7ab29d64d891f3288f8042d267dcc82a32e9 > src/tests/reservation_endpoints_tests.cpp > 35c093567b07a11ca6eee85e2ff91894a460a7af > > Diff: https://reviews.apache.org/r/42689/diff/ > > > Testing > --- > > Seems like these snuck in due to copy-and-pastes that were concurrent with > the patch to fixup the rest of the instances of this comment. > > > Thanks, > > Neil Conway > >
Re: Review Request 42689: Clarified a comment that occurs in several test cases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42689/#review116003 --- Patch looks great! Reviews applied: [42689] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 23, 2016, 11:05 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42689/ > --- > > (Updated Jan. 23, 2016, 11:05 p.m.) > > > Review request for mesos and Adam B. > > > Repository: mesos > > > Description > --- > > Clarified a comment that occurs in several test cases. > > > Diffs > - > > src/tests/persistent_volume_tests.cpp > 7acf7ab29d64d891f3288f8042d267dcc82a32e9 > src/tests/reservation_endpoints_tests.cpp > 35c093567b07a11ca6eee85e2ff91894a460a7af > > Diff: https://reviews.apache.org/r/42689/diff/ > > > Testing > --- > > Seems like these snuck in due to copy-and-pastes that were concurrent with > the patch to fixup the rest of the instances of this comment. > > > Thanks, > > Neil Conway > >
Review Request 42689: Clarified a comment that occurs in several test cases.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42689/ --- Review request for mesos and Adam B. Repository: mesos Description --- Clarified a comment that occurs in several test cases. Diffs - src/tests/persistent_volume_tests.cpp 7acf7ab29d64d891f3288f8042d267dcc82a32e9 src/tests/reservation_endpoints_tests.cpp 35c093567b07a11ca6eee85e2ff91894a460a7af Diff: https://reviews.apache.org/r/42689/diff/ Testing --- Seems like these snuck in due to copy-and-pastes that were concurrent with the patch to fixup the rest of the instances of this comment. Thanks, Neil Conway
