Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread haosdent huang 


> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote:
> > Could you please explain in description why disabling checkpointing speeds 
> > up the test and why it is ok to disable it for these tests?
> 
> haosdent huang wrote:
> Sure!
> 
> Bernd Mathiske wrote:
> Not writing to disk costs less time.
> 
> If a test does not attempt recovery, then whatever would be checkpointed 
> never gets used.
> 
> Only one test attempts/tests recovery so far. In this test we do apply 
> checkpointing. So it does get tested, but we don't need to test the writing 
> part of it in every other test.
> 
> Alexander Rukletsov wrote:
> I'm a bit confused about what contributes most here. Is it checkpointing 
> or rather the other change? It's a bit strange to me that checkpointing 
> significantly influences the test duration. If so, I would like to understand 
> why, of not, them maybe we can pull it out of the change to avoid 
> distraction. Also It's not clear at the first glance why it's ok to reduce 
> some loops in the tests and why they were there in the first place.
> 
> it would be great to have one fix per patch with explanation why it helps 
> and how much.

>it would be great to have one fix per patch with explanation why it helps and 
>how much.

Sure. My test machine is use SATA disk. And becsue we write to disk when 
status_update, would cause >100 ms delay when I testing. I agree with you. Let 
me split up them and explain why it helps and how much.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119294
---


On Feb. 16, 2016, 11:39 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 16, 2016, 11:39 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread Alexander Rukletsov 


> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote:
> > Could you please explain in description why disabling checkpointing speeds 
> > up the test and why it is ok to disable it for these tests?
> 
> haosdent huang wrote:
> Sure!
> 
> Bernd Mathiske wrote:
> Not writing to disk costs less time.
> 
> If a test does not attempt recovery, then whatever would be checkpointed 
> never gets used.
> 
> Only one test attempts/tests recovery so far. In this test we do apply 
> checkpointing. So it does get tested, but we don't need to test the writing 
> part of it in every other test.

I'm a bit confused about what contributes most here. Is it checkpointing or 
rather the other change? It's a bit strange to me that checkpointing 
significantly influences the test duration. If so, I would like to understand 
why, of not, them maybe we can pull it out of the change to avoid distraction. 
Also It's not clear at the first glance why it's ok to reduce some loops in the 
tests and why they were there in the first place.

it would be great to have one fix per patch with explanation why it helps and 
how much.


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119294
---


On Feb. 16, 2016, 11:39 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 16, 2016, 11:39 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119302
---


Ship it!




- Benjamin Bannier


On Feb. 16, 2016, 12:39 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 16, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
---

(Updated Feb. 16, 2016, 11:39 a.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Address @bbannier and @alex-mesos comments.


Bugs: MESOS-4486
https://issues.apache.org/jira/browse/MESOS-4486


Repository: mesos


Description
---

Speed up FetcherCacheTest.Local* test cases.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/42696/diff/


Testing
---

Before apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[   OK ] FetcherCacheTest.LocalUncached (2580 ms)
[   OK ] FetcherCacheTest.LocalCached (2524 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
```


After apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[   OK ] FetcherCacheTest.LocalUncached (873 ms)
[   OK ] FetcherCacheTest.LocalCached (1609 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
```

Also test the recovery test manually:

```
sudo ./bin/mesos-tests.sh 
--gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
```


Thanks,

haosdent huang

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread Bernd Mathiske 


> On Feb. 16, 2016, 3:02 a.m., Alexander Rukletsov wrote:
> > Could you please explain in description why disabling checkpointing speeds 
> > up the test and why it is ok to disable it for these tests?
> 
> haosdent huang wrote:
> Sure!

Not writing to disk costs less time.

If a test does not attempt recovery, then whatever would be checkpointed never 
gets used.

Only one test attempts/tests recovery so far. In this test we do apply 
checkpointing. So it does get tested, but we don't need to test the writing 
part of it in every other test.


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119294
---


On Feb. 9, 2016, 4:48 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 9, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread haosdent huang 


> On Feb. 16, 2016, 11:02 a.m., Alexander Rukletsov wrote:
> > Could you please explain in description why disabling checkpointing speeds 
> > up the test and why it is ok to disable it for these tests?

Sure!


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119294
---


On Feb. 10, 2016, 12:48 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 10, 2016, 12:48 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119291
---




src/tests/fetcher_cache_tests.cpp (line 115)


Please add a virtual dtr here for completeness, i.e., `virtual 
~FetcherCacheTest() = default;`.



src/tests/fetcher_cache_tests.cpp (line 147)


Maybe something like "Whether to checkpoint frameworks." instead?



src/tests/fetcher_cache_tests.cpp (line 148)


This should be `const`, i.e., `virtual bool checkpoint() const`.



src/tests/fetcher_cache_tests.cpp (line 199)


`this->` is redundant, please remove.


- Benjamin Bannier


On Feb. 10, 2016, 1:48 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 10, 2016, 1:48 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119294
---



Could you please explain in description why disabling checkpointing speeds up 
the test and why it is ok to disable it for these tests?

- Alexander Rukletsov


On Feb. 10, 2016, 12:48 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 10, 2016, 12:48 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-16 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review119290
---


Ship it!




Ship It!

- Bernd Mathiske


On Feb. 9, 2016, 4:48 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Feb. 9, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-09 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
---

(Updated Feb. 9, 2016, 6:17 p.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Rebase


Bugs: MESOS-4486
https://issues.apache.org/jira/browse/MESOS-4486


Repository: mesos


Description
---

Speed up FetcherCacheTest.Local* test cases.


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 
6b81bf1ea3d571e8f5fb170076b85223b02efe2c 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
182ac9cfbacd4535fb355aac6ec38559d786e63a 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 
692fa483ee8a75dedae5ad0e7d2a4aa70dafa8a3 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/sunos.hpp 
ec8e1f7562d5747113631351e6d8ff8989cf0fed 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
84a2a021859d4e5c8547ad2a509eebda428a8255 
  CHANGELOG fc387dc83d919228129ea1ef4ac6c17a8fb55a04 
  Makefile.am 2b43854b0d36e4ee9c24a0c6f67480c697b8684a 
  configure.ac b9a99060fe02f95ee1dca4a28deec200301e320b 
  docs/endpoints/files/browse.json.md 7c7049344980a16978a25431e713fbfe61e1cc5f 
  docs/endpoints/files/browse.md 5aa685ad616116168db852ba49e063115f7671f2 
  docs/endpoints/files/debug.json.md 3e41fec14d014a46d3a8a0ffddf7f162a39b1347 
  docs/endpoints/files/debug.md f3ff3819b14fad3aa9ddf70169c2955d18595e85 
  docs/endpoints/files/download.json.md 
77c6b97988c30ddcd71d69da1ffa55a10e871051 
  docs/endpoints/files/download.md 2b8b3f564a55b18bb84d0268b4f7a20e92b05bea 
  docs/endpoints/files/read.json.md f86f22727a7d746e8047560a88f15ab82864c062 
  docs/endpoints/files/read.md 31dd90cf0c834aca3d130f5e856fb19c7d8500cc 
  docs/endpoints/index.md 69d2157f1edf96f608e1d6eaf5a81f2421286415 
  docs/endpoints/logging/toggle.md baa4d1b60ed7c55b75f12fdf4e2c10d062bfcb48 
  docs/endpoints/master/api/v1/scheduler.md 
6faa1c2449acc54a5dc0a240959ed70a9cd7c237 
  docs/endpoints/master/create-volumes.md 
f167452377787920414e8e1ec7712556dae29a65 
  docs/endpoints/master/destroy-volumes.md 
a9a12adc017d61f77ddacc26c84daa37657c2355 
  docs/endpoints/master/flags.md b63b6e2fc837aa59341d38dab96c14bd9ed63c46 
  docs/endpoints/master/frameworks.md bc21f1e3818cf259a5ee2da258afb29afdb7b82a 
  docs/endpoints/master/health.md 39af4f963c8d84d64d4c9dafa89f4e9129242f77 
  docs/endpoints/master/machine/down.md 
82cce61e2a02f7896e7db351bed7a08138e87768 
  docs/endpoints/master/machine/up.md 5bfd95e0945d82030ee536ee247665c455629a64 
  docs/endpoints/master/maintenance/schedule.md 
e91ee81a07b09b36db9c3c9eff36f0dbb515fdd0 
  docs/endpoints/master/maintenance/status.md 
17e3eef1c2fac12375892ec125a727a62a4ebfca 
  docs/endpoints/master/observe.md acdc18c65798e90459b2b595cc3c72a11f739be2 
  docs/endpoints/master/quota.md 26c7bb162f29db1542a4ac2d61368724436e835a 
  docs/endpoints/master/redirect.md 4a230e4b7438f8b265c4f5d0a2e5b91f888b39fe 
  docs/endpoints/master/reserve.md 6d4dee457b79ffd6db1520ab49c5c3331290510e 
  docs/endpoints/master/roles.json.md d67779c246cceae2209f2611f32ada4493ae6f83 
  docs/endpoints/master/roles.md 976a9b7891a17652289126ec7e7ee73cea0c2e35 
  docs/endpoints/master/slaves.md 0be05d79d6480038ca5cfc088b7b476315514027 
  docs/endpoints/master/state-summary.md 
a6d79f0e5703c3f9118869e287fbb512e86c22c0 
  docs/endpoints/master/state.json.md e13993e12526cba47ea7bd1e6f53acc62305250d 
  docs/endpoints/master/state.md 7571d31bc0d653644fda7c0cfa2fbf3e414314d7 
  docs/endpoints/master/tasks.json.md cb1856f296d7420ce3162a60bf634de0991cdde4 
  docs/endpoints/master/tasks.md e8dbf9370433ee34fc475f5dfebfc15d3b5c62e1 
  docs/endpoints/master/teardown.md 9cd86399b532d79d0b1da451320c7f01b948d513 
  docs/endpoints/master/unreserve.md 81c72d3253141586d6dbe278a07ce1ff179488c6 
  docs/endpoints/metrics/snapshot.md ab37ab47e4a1692d805698b45d101905029747b5 
  docs/endpoints/monitor/statistics.json.md 
5ce4fc69aaa4b54541841e58ffa29703363b73e2 
  docs/endpoints/monitor/statistics.md 602104b2484022cfa7f41b04affc106703e6f09f 
  docs/endpoints/profiler/start.md 244fd6f6e4695165ff23bc33302b76974bc3f321 
  docs/endpoints/profiler/stop.md 6b9738abd8a0b4247fbd1dfd7c3c145cf1b51f9f 
  docs/endpoints/registrar/registry.md 12b11fe62edfe47cc639fd5cd5224c04d93a24f9 
  docs/endpoints/slave/api/v1/executor.md 
e92df49b0a50e0152e54866e812438c9af63c4e0 
  docs/endpoints/slave/flags.md 8abbc72f14854cf2cdaab37f9858e9427394ea7e 
  docs/endpoints/slave/health.md 265dcfaaa46dfe86dcf8ed7c5357e1ac05bb1dae 
  docs/endpoints/slave/state.json.md 10f7a7487c3ab76af7d46c5e7deddf724a3df2c1 
  docs/endpoints/slave/state.md 40df6a810b3fd2cae113959d4f42a0c19afbd5d2 
  docs/endpoints/system/stats.json.md a5fb58f35c602c8b03ed911eb374d26f98449585 
  docs/endpoints/version.md 07a9f6c7c2e0239b428dcadabc9e81f7fce05d67 
  site/README.md 78609fb68182338199b4d0ad4c333c8f34274ee5 
  src/Makefile.am

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-02-09 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
---

(Updated Feb. 10, 2016, 12:48 a.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Rebase.


Bugs: MESOS-4486
https://issues.apache.org/jira/browse/MESOS-4486


Repository: mesos


Description
---

Speed up FetcherCacheTest.Local* test cases.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/42696/diff/


Testing
---

Before apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[   OK ] FetcherCacheTest.LocalUncached (2580 ms)
[   OK ] FetcherCacheTest.LocalCached (2524 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
```


After apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[   OK ] FetcherCacheTest.LocalUncached (873 ms)
[   OK ] FetcherCacheTest.LocalCached (1609 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
```

Also test the recovery test manually:

```
sudo ./bin/mesos-tests.sh 
--gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
```


Thanks,

haosdent huang

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-26 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review116330
---




src/tests/fetcher_cache_tests.cpp (line 196)


Good idea, but then we need to set checkpointing to true for the recovery 
test below.



src/tests/fetcher_cache_tests.cpp (line 599)


const



src/tests/fetcher_cache_tests.cpp (line 713)


const


- Bernd Mathiske


On Jan. 24, 2016, 7:01 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Jan. 24, 2016, 7:01 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-26 Thread haosdent huang 


> On Jan. 26, 2016, 9:18 a.m., Bernd Mathiske wrote:
> > src/tests/fetcher_cache_tests.cpp, line 196
> > 
> >
> > Good idea, but then we need to set checkpointing to true for the 
> > recovery test below.

@bernd, thank you very much. Could you help review again?


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review116330
---


On Jan. 27, 2016, 3:04 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Jan. 27, 2016, 3:04 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-26 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review116547
---



Patch looks great!

Reviews applied: [42696]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 27, 2016, 3:04 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Jan. 27, 2016, 3:04 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> Also test the recovery test manually:
> 
> ```
> sudo ./bin/mesos-tests.sh 
> --gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-26 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
---

(Updated Jan. 27, 2016, 3:04 a.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Address @bernd's comments.


Bugs: MESOS-4486
https://issues.apache.org/jira/browse/MESOS-4486


Repository: mesos


Description
---

Speed up FetcherCacheTest.Local* test cases.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 

Diff: https://reviews.apache.org/r/42696/diff/


Testing (updated)
---

Before apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[   OK ] FetcherCacheTest.LocalUncached (2580 ms)
[   OK ] FetcherCacheTest.LocalCached (2524 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
```


After apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[   OK ] FetcherCacheTest.LocalUncached (873 ms)
[   OK ] FetcherCacheTest.LocalCached (1609 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
```

Also test the recovery test manually:

```
sudo ./bin/mesos-tests.sh 
--gtest_filter="FetcherCacheHttpRecoveryTest.HttpCachedRecovery"
```


Thanks,

haosdent huang

Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-24 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/
---

Review request for mesos and Bernd Mathiske.


Bugs: MESOS-4486
https://issues.apache.org/jira/browse/MESOS-4486


Repository: mesos


Description
---

Speed up FetcherCacheTest.Local* test cases.


Diffs
-

  src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 

Diff: https://reviews.apache.org/r/42696/diff/


Testing
---

Before apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[   OK ] FetcherCacheTest.LocalUncached (2580 ms)
[   OK ] FetcherCacheTest.LocalCached (2524 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
```


After apply the patch:
```
$ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
[   OK ] FetcherCacheTest.LocalUncached (873 ms)
[   OK ] FetcherCacheTest.LocalCached (1609 ms)
[   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
[   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
```


Thanks,

haosdent huang

Re: Review Request 42696: Speed up FetcherCacheTest.Local* test cases.

2016-01-24 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42696/#review116022
---



Patch looks great!

Reviews applied: [42696]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 24, 2016, 3:01 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42696/
> ---
> 
> (Updated Jan. 24, 2016, 3:01 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4486
> https://issues.apache.org/jira/browse/MESOS-4486
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up FetcherCacheTest.Local* test cases.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 2747b72ba49c9fde04e556b649601b037517283e 
> 
> Diff: https://reviews.apache.org/r/42696/diff/
> 
> 
> Testing
> ---
> 
> Before apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (2580 ms)
> [   OK ] FetcherCacheTest.LocalCached (2524 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (2514 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (2551 ms)
> ```
> 
> 
> After apply the patch:
> ```
> $ sudo ./bin/mesos-tests.sh --gtest_filter="FetcherCacheTest.Local*"
> [   OK ] FetcherCacheTest.LocalUncached (873 ms)
> [   OK ] FetcherCacheTest.LocalCached (1609 ms)
> [   OK ] FetcherCacheTest.LocalUncachedExtract (926 ms)
> [   OK ] FetcherCacheTest.LocalCachedExtract (1509 ms)
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>