Review Request 42972: stout: Fixed typo (unintended inequality between pointer value and 0).

2016-01-29 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42972/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 42972: stout: Fixed typo (unintended inequality between pointer value and 0).

2016-01-29 Thread Anand Mazumdar
> On Jan. 29, 2016, 7:50 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 624 > > > > > > Not yours: Should we add a `CHECK_NOTNULL` before this statement now? >

Re: Review Request 42972: stout: Fixed typo (unintended inequality between pointer value and 0).

2016-01-29 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42972/#review116993 --- Ship it!

Re: Review Request 42972: stout: Fixed typo (unintended inequality between pointer value and 0).

2016-01-29 Thread Neil Conway
> On Jan. 29, 2016, 7:50 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 624 > > > > > > Not yours: Should we add a `CHECK_NOTNULL` before this statement now?

Re: Review Request 42972: stout: Fixed typo (unintended inequality between pointer value and 0).

2016-01-29 Thread Neil Conway
> On Jan. 29, 2016, 7:50 p.m., Anand Mazumdar wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 624 > > > > > > Not yours: Should we add a `CHECK_NOTNULL` before this statement now? >