Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

2016-02-09 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/#review118392
---


Ship it!




Ship It!

- Jie Yu


On Feb. 8, 2016, 7:19 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42982/
> ---
> 
> (Updated Feb. 8, 2016, 7:19 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4487
> https://issues.apache.org/jira/browse/MESOS-4487
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Defined a virtual `status` method for Containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.hpp 
> 08d1ed3cf50f50b5b6e71df60bffbd141490ad32 
> 
> Diff: https://reviews.apache.org/r/42982/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

2016-02-08 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/#review118261
---


Fix it, then Ship it!





src/slave/containerizer/containerizer.hpp (line 118)


Put '{' in the next line.


- Jie Yu


On Feb. 5, 2016, 3:35 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42982/
> ---
> 
> (Updated Feb. 5, 2016, 3:35 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4487
> https://issues.apache.org/jira/browse/MESOS-4487
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Defined a virtual `status` method for Containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/containerizer.hpp 
> 08d1ed3cf50f50b5b6e71df60bffbd141490ad32 
> 
> Diff: https://reviews.apache.org/r/42982/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

2016-02-08 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/
---

(Updated Feb. 8, 2016, 7:19 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487


Repository: mesos


Description
---

Defined a virtual `status` method for Containerizer.


Diffs (updated)
-

  src/slave/containerizer/containerizer.hpp 
08d1ed3cf50f50b5b6e71df60bffbd141490ad32 

Diff: https://reviews.apache.org/r/42982/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

2016-02-05 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/
---

(Updated Feb. 5, 2016, 3:35 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487


Repository: mesos


Description
---

Defined a virtual `status` method for Containerizer.


Diffs
-

  src/slave/containerizer/containerizer.hpp 
08d1ed3cf50f50b5b6e71df60bffbd141490ad32 

Diff: https://reviews.apache.org/r/42982/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

2016-02-05 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/
---

(Updated Feb. 5, 2016, 3:35 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487


Repository: mesos


Description
---

Defined a virtual `status` method for Containerizer.


Diffs (updated)
-

  src/slave/containerizer/containerizer.hpp 
08d1ed3cf50f50b5b6e71df60bffbd141490ad32 

Diff: https://reviews.apache.org/r/42982/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 42982: Defined a virtual `status` method for Containerizer.

2016-02-04 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/
---

(Updated Feb. 4, 2016, 6:41 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487


Repository: mesos


Description
---

Defined a virtual `status` method for Containerizer.


Diffs (updated)
-

  src/slave/containerizer/containerizer.hpp 
08d1ed3cf50f50b5b6e71df60bffbd141490ad32 

Diff: https://reviews.apache.org/r/42982/diff/


Testing
---

make


Thanks,

Avinash sridharan

Review Request 42982: Defined a virtual `status` method for Containerizer.

2016-02-02 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42982/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487


Repository: mesos


Description
---

Defined a virtual `status` method for Containerizer.


Diffs
-

  src/slave/containerizer/containerizer.hpp 
08d1ed3cf50f50b5b6e71df60bffbd141490ad32 

Diff: https://reviews.apache.org/r/42982/diff/


Testing
---

make


Thanks,

Avinash sridharan