Re: Review Request 43131: Modified existing usage of Slave constructor.

2016-02-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43131/#review117870 --- Ship it! Ship It! - Vinod Kone On Feb. 3, 2016, 10:40 p.m.,

Re: Review Request 43131: Modified existing usage of Slave constructor.

2016-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43131/#review117678 --- src/slave/main.cpp (line 211)

Re: Review Request 43131: Modified existing usage of Slave constructor.

2016-02-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43131/ --- (Updated Feb. 3, 2016, 10:02 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43131: Modified existing usage of Slave constructor.

2016-02-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43131/ --- (Updated Feb. 3, 2016, 10:40 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43131: Modified existing usage of Slave constructor.

2016-02-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43131/#review117660 --- src/slave/main.cpp (line 211)

Re: Review Request 43131: Modified existing usage of Slave constructor.

2016-02-03 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43131/ --- (Updated Feb. 3, 2016, 7:56 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 43131: Modified existing usage of Slave constructor.

2016-02-03 Thread Anand Mazumdar
> On Feb. 3, 2016, 7:51 p.m., Vinod Kone wrote: > > src/slave/main.cpp, line 211 > > > > > > this is backwards incompatible. this will need to go through a > > deprecation cycle with a warning to the dev/user list.

Re: Review Request 43131: Modified existing usage of Slave constructor.

2016-02-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43131/ --- (Updated Feb. 3, 2016, 2:34 a.m.) Review request for mesos and Vinod Kone.