Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review126969 --- Ship it! Ship It! - Joris Van Remoortere On March 30, 2016,

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated March 30, 2016, 5:12 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated March 30, 2016, 5:10 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review126091 --- Can you please split the review between the code update and the

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On March 29, 2016, 12:52 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/process.cpp, line 2193 > > > > > > since this value will not longer always map to the number of `cpus`, > > can we rename

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated March 29, 2016, 11:14 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review125864 --- 3rdparty/libprocess/src/process.cpp (line 2193)

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated March 28, 2016, 8:28 p.m.) Review request for mesos, Guangya Liu,

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On Feb. 6, 2016, 7:39 p.m., Guangya Liu wrote: > > @Maged, I think that you can now find a shephard for this. You can post an > > email to d...@mesos.apache.org to ask for a shephard for MESOS-4353 Folks, generally the expectation is that the shepherd is found *before* the code gets written

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On Feb. 6, 2016, 10:11 a.m., Guangya Liu wrote: > > docs/configuration.md, lines 1679-1682 > > > > > > How about: Libprocess will normally use a thread pool sized according > > to the number of active CPUs. This

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On Feb. 6, 2016, 10:11 a.m., Guangya Liu wrote: > > docs/configuration.md, lines 1679-1682 > > > > > > How about: Libprocess will normally use a thread pool sized according > > to the number of active CPUs. This

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On 二月 6, 2016, 10:11 a.m., Guangya Liu wrote: > > docs/configuration.md, lines 1679-1682 > > > > > > How about: Libprocess will normally use a thread pool sized according > > to the number of active CPUs. This

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review118168 --- @Maged, I think that you can now find a shephard for this. You

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated Feb. 7, 2016, 3:34 a.m.) Review request for mesos, Guangya Liu, Klaus

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review118141 --- docs/configuration.md (lines 1679 - 1682)

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On Feb. 5, 2016, 2:20 p.m., Qian Zhang wrote: > > 1. Besides changing the code, you may also need to update the following doc > > to describe the newly introduced env var "LIBPROCESS_MAX_WORKER_THREADS" > > https://github.com/apache/mesos/blob/master/docs/configuration.md#libprocess-options >

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated Feb. 5, 2016, 9:45 p.m.) Review request for mesos and Klaus Ma.

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review118012 --- 1. Besides changing the code, you may also need to update the

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On Feb. 4, 2016, 9:38 p.m., Klaus Ma wrote: > > 3rdparty/libprocess/src/process.cpp, line 2211 > > > > > > Just `os::getenv("LIB...")` is OK. > > Maged Michael wrote: > The string is used in two places:

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On 二月 5, 2016, 2:51 a.m., Guangya Liu wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2212-2213 > > > > > > Why not > > > > Option value = os::getenv("LIBPROCESS_MAX_WORKER_THREADS"); I see what

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review117947 --- The document should also be updated `docs/configuration.md` by

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/#review117975 --- 3rdparty/libprocess/src/process.cpp (line )

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On Feb. 5, 2016, 2:51 a.m., Guangya Liu wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2212-2213 > > > > > > Why not > > > > Option value = os::getenv("LIBPROCESS_MAX_WORKER_THREADS"); > >

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated Feb. 5, 2016, 3:39 a.m.) Review request for mesos and Klaus Ma.

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On 二月 5, 2016, 2:51 a.m., Guangya Liu wrote: > > 3rdparty/libprocess/src/process.cpp, line > > > > > > I think that warning message should also be enhanced that > > > > `"Ignoring invalid value "

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated Feb. 4, 2016, 7:25 p.m.) Review request for mesos and Klaus Ma.

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

> On Feb. 4, 2016, 1:38 p.m., Klaus Ma wrote: > > 3rdparty/libprocess/src/process.cpp, line 2202 > > > > > > blank line before. Fixed. Updated patch. > On Feb. 4, 2016, 1:38 p.m., Klaus Ma wrote: > >

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated Feb. 4, 2016, 7:09 p.m.) Review request for mesos and Klaus Ma.

Re: Review Request 43144: Added env var to set upper bound on number of libprocess worker threads.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43144/ --- (Updated Feb. 4, 2016, 7:55 p.m.) Review request for mesos and Klaus Ma.