Re: Review Request 43156: Added test: dynamic reservations with same role, different principals.

2016-02-09 Thread Michael Park

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43156/#review118535
---


Ship it!




Ship It!

- Michael Park


On Feb. 5, 2016, 5:47 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43156/
> ---
> 
> (Updated Feb. 5, 2016, 5:47 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4590
> https://issues.apache.org/jira/browse/MESOS-4590
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test: dynamic reservations with same role, different principals.
> 
> 
> Diffs
> -
> 
>   src/tests/reservation_endpoints_tests.cpp 
> 35c093567b07a11ca6eee85e2ff91894a460a7af 
> 
> Diff: https://reviews.apache.org/r/43156/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 43156: Added test: dynamic reservations with same role, different principals.

2016-02-05 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43156/#review118139
---


Ship it!




Ship It!

- Guangya Liu


On 二月 5, 2016, 5:47 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43156/
> ---
> 
> (Updated 二月 5, 2016, 5:47 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4590
> https://issues.apache.org/jira/browse/MESOS-4590
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test: dynamic reservations with same role, different principals.
> 
> 
> Diffs
> -
> 
>   src/tests/reservation_endpoints_tests.cpp 
> 35c093567b07a11ca6eee85e2ff91894a460a7af 
> 
> Diff: https://reviews.apache.org/r/43156/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Review Request 43156: Added test: dynamic reservations with same role, different principals.

2016-02-05 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43156/
---

Review request for mesos and Michael Park.


Bugs: MESOS-4590
https://issues.apache.org/jira/browse/MESOS-4590


Repository: mesos


Description
---

Added test: dynamic reservations with same role, different principals.


Diffs
-

  src/tests/reservation_endpoints_tests.cpp 
35c093567b07a11ca6eee85e2ff91894a460a7af 

Diff: https://reviews.apache.org/r/43156/diff/


Testing
---

make check


Thanks,

Neil Conway



Re: Review Request 43156: Added test: dynamic reservations with same role, different principals.

2016-02-05 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43156/#review118085
---



Patch looks great!

Reviews applied: [43156]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 5, 2016, 5:47 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43156/
> ---
> 
> (Updated Feb. 5, 2016, 5:47 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4590
> https://issues.apache.org/jira/browse/MESOS-4590
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test: dynamic reservations with same role, different principals.
> 
> 
> Diffs
> -
> 
>   src/tests/reservation_endpoints_tests.cpp 
> 35c093567b07a11ca6eee85e2ff91894a460a7af 
> 
> Diff: https://reviews.apache.org/r/43156/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>