Re: Review Request 43201: Updated reservation documentation.

2016-02-11 Thread Greg Mann 


> On Feb. 11, 2016, 2:59 a.m., Guangya Liu wrote:
> > docs/reservation.md, lines 61-63
> > 
> >
> > What about putting NOTE to a new line?
> > 
> > > NOTE: As of 0.27.0, these endpoints cannot be used when HTTP 
> > authentication is disabled due to the current implementation. This will 
> > change in version 0.28.0.
> 
> Greg Mann wrote:
> I tried this and viewed it using the website Docker container. It turns 
> out, forcing a newline before the "NOTE:" also inserts a vertical space, so 
> it's less obvious that the "NOTE" is meant to apply to only the second 
> bullet-point. I think it looks a bit better if we leave this passage as it 
> is, let me know what you think.
> 
> Guangya Liu wrote:
> There are different kinds of `NOTE` in the documents, but most of the 
> `NOTE` start from a new line, that's why I propose that we use a new line to 
> highlight `NOTE`.
> 
> 1) 
> https://github.com/apache/mesos/blob/master/docs/upgrades.md#upgrading-from-022x-to-023x
> 2) 
> https://github.com/apache/mesos/blob/master/docs/slave-recovery.md#enabling-slave-checkpointing
> 3) 
> https://github.com/apache/mesos/blob/master/docs/upgrades.md#upgrading-from-0140-to-0150

In link #2, I actually see a number of NOTEs which do not use a newline. They 
are placed in a bullet point list, which is the same as in this patch. The 
problem is that in order to insert a newline in the bullet point list, you also 
have to insert a vertical space, which makes it less obvious what the NOTE is 
referring to.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/#review118806
---


On Feb. 11, 2016, 1:39 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43201/
> ---
> 
> (Updated Feb. 11, 2016, 1:39 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated reservation documentation.
> 
> Clarified differences between the RESERVE offer operation and the `/reserve` 
> operator endpoint.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43201/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43201: Updated reservation documentation.

2016-02-10 Thread Guangya Liu 


> On 二月 11, 2016, 2:59 a.m., Guangya Liu wrote:
> > docs/reservation.md, lines 61-63
> > 
> >
> > What about putting NOTE to a new line?
> > 
> > > NOTE: As of 0.27.0, these endpoints cannot be used when HTTP 
> > authentication is disabled due to the current implementation. This will 
> > change in version 0.28.0.
> 
> Greg Mann wrote:
> I tried this and viewed it using the website Docker container. It turns 
> out, forcing a newline before the "NOTE:" also inserts a vertical space, so 
> it's less obvious that the "NOTE" is meant to apply to only the second 
> bullet-point. I think it looks a bit better if we leave this passage as it 
> is, let me know what you think.

There are different kinds of `NOTE` in the documents, but most of the `NOTE` 
start from a new line, that's why I propose that we use a new line to highlight 
`NOTE`.

1) 
https://github.com/apache/mesos/blob/master/docs/upgrades.md#upgrading-from-022x-to-023x
2) 
https://github.com/apache/mesos/blob/master/docs/slave-recovery.md#enabling-slave-checkpointing
3) 
https://github.com/apache/mesos/blob/master/docs/upgrades.md#upgrading-from-0140-to-0150


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/#review118806
---


On 二月 11, 2016, 1:39 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43201/
> ---
> 
> (Updated 二月 11, 2016, 1:39 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated reservation documentation.
> 
> Clarified differences between the RESERVE offer operation and the `/reserve` 
> operator endpoint.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43201/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43201: Updated reservation documentation.

2016-02-10 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/#review118830
---



Patch looks great!

Reviews applied: [43199, 43200, 43201]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 11, 2016, 1:39 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43201/
> ---
> 
> (Updated Feb. 11, 2016, 1:39 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated reservation documentation.
> 
> Clarified differences between the RESERVE offer operation and the `/reserve` 
> operator endpoint.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43201/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43201: Updated reservation documentation.

2016-02-10 Thread Greg Mann 


> On Feb. 11, 2016, 2:59 a.m., Guangya Liu wrote:
> > docs/reservation.md, lines 61-63
> > 
> >
> > What about putting NOTE to a new line?
> > 
> > > NOTE: As of 0.27.0, these endpoints cannot be used when HTTP 
> > authentication is disabled due to the current implementation. This will 
> > change in version 0.28.0.

I tried this and viewed it using the website Docker container. It turns out, 
forcing a newline before the "NOTE:" also inserts a vertical space, so it's 
less obvious that the "NOTE" is meant to apply to only the second bullet-point. 
I think it looks a bit better if we leave this passage as it is, let me know 
what you think.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/#review118806
---


On Feb. 11, 2016, 1:39 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43201/
> ---
> 
> (Updated Feb. 11, 2016, 1:39 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated reservation documentation.
> 
> Clarified differences between the RESERVE offer operation and the `/reserve` 
> operator endpoint.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43201/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43201: Updated reservation documentation.

2016-02-10 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/#review118806
---


Fix it, then Ship it!





docs/reservation.md (lines 61 - 63)


What about putting NOTE to a new line?

> NOTE: As of 0.27.0, these endpoints cannot be used when HTTP 
authentication is disabled due to the current implementation. This will change 
in version 0.28.0.


- Guangya Liu


On 二月 11, 2016, 1:39 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43201/
> ---
> 
> (Updated 二月 11, 2016, 1:39 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated reservation documentation.
> 
> Clarified differences between the RESERVE offer operation and the `/reserve` 
> operator endpoint.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43201/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43201: Updated reservation documentation.

2016-02-10 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/
---

(Updated Feb. 11, 2016, 1:39 a.m.)


Review request for mesos, Neil Conway and Vinod Kone.


Bugs: MESOS-4452
https://issues.apache.org/jira/browse/MESOS-4452


Repository: mesos


Description
---

Updated reservation documentation.

Clarified differences between the RESERVE offer operation and the `/reserve` 
operator endpoint.


Diffs (updated)
-

  docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 

Diff: https://reviews.apache.org/r/43201/diff/


Testing
---

Viewed in the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 43201: Updated reservation documentation.

2016-02-10 Thread Greg Mann 


> On Feb. 10, 2016, 7:38 a.m., Adam B wrote:
> > docs/reservation.md, lines 56-57
> > 
> >
> > How about: "Each framework may only reserve resources for its own role."

Changed.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/#review118609
---


On Feb. 11, 2016, 1:39 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43201/
> ---
> 
> (Updated Feb. 11, 2016, 1:39 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated reservation documentation.
> 
> Clarified differences between the RESERVE offer operation and the `/reserve` 
> operator endpoint.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43201/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43201: Updated reservation documentation.

2016-02-09 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/
---

(Updated Feb. 9, 2016, 7:32 p.m.)


Review request for mesos, Neil Conway and Vinod Kone.


Bugs: MESOS-4452
https://issues.apache.org/jira/browse/MESOS-4452


Repository: mesos


Description
---

Updated reservation documentation.

Clarified differences between the RESERVE offer operation and the `/reserve` 
operator endpoint.


Diffs (updated)
-

  docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 

Diff: https://reviews.apache.org/r/43201/diff/


Testing
---

Viewed in the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann

Re: Review Request 43201: Updated reservation documentation.

2016-02-09 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/#review118497
---



Patch looks great!

Reviews applied: [43199, 43200, 43201]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 9, 2016, 7:32 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43201/
> ---
> 
> (Updated Feb. 9, 2016, 7:32 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated reservation documentation.
> 
> Clarified differences between the RESERVE offer operation and the `/reserve` 
> operator endpoint.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43201/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43201: Updated reservation documentation.

2016-02-09 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/#review118609
---


Fix it, then Ship it!





docs/reservation.md (lines 56 - 57)


How about: "Each framework may only reserve resources for its own role."



docs/reservation.md (lines 61 - 62)


Please insert your new sentence before the versioning "NOTE"


- Adam B


On Feb. 9, 2016, 11:32 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43201/
> ---
> 
> (Updated Feb. 9, 2016, 11:32 a.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated reservation documentation.
> 
> Clarified differences between the RESERVE offer operation and the `/reserve` 
> operator endpoint.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43201/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43201: Updated reservation documentation.

2016-02-09 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/#review118608
---




docs/reservation.md (line 62)


`Operators may reserve resources for any role.`

This may also be changed once MESOS-4591 got fixed? Do we need to mention 
that this is not true once MESOS-4591 fixed?


- Guangya Liu


On 二月 9, 2016, 7:32 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43201/
> ---
> 
> (Updated 二月 9, 2016, 7:32 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated reservation documentation.
> 
> Clarified differences between the RESERVE offer operation and the `/reserve` 
> operator endpoint.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43201/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43201: Updated reservation documentation.

2016-02-08 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/#review118352
---



Patch looks great!

Reviews applied: [43201]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 4, 2016, 7:01 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43201/
> ---
> 
> (Updated Feb. 4, 2016, 7:01 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated reservation documentation.
> 
> Clarified differences between the RESERVE offer operation and the `/reserve` 
> operator endpoint.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43201/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 43201: Updated reservation documentation.

2016-02-08 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/#review118328
---


Fix it, then Ship it!





docs/reservation.md (line 44)


not yours but can you s/This/That/ ?


- Vinod Kone


On Feb. 4, 2016, 7:01 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43201/
> ---
> 
> (Updated Feb. 4, 2016, 7:01 p.m.)
> 
> 
> Review request for mesos, Neil Conway and Vinod Kone.
> 
> 
> Bugs: MESOS-4452
> https://issues.apache.org/jira/browse/MESOS-4452
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated reservation documentation.
> 
> Clarified differences between the RESERVE offer operation and the `/reserve` 
> operator endpoint.
> 
> 
> Diffs
> -
> 
>   docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 
> 
> Diff: https://reviews.apache.org/r/43201/diff/
> 
> 
> Testing
> ---
> 
> Viewed in the mesos website container: 
> https://github.com/mesosphere/mesos-website-container
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Review Request 43201: Updated reservation documentation.

2016-02-04 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43201/
---

Review request for mesos, Neil Conway and Vinod Kone.


Bugs: MESOS-4452
https://issues.apache.org/jira/browse/MESOS-4452


Repository: mesos


Description
---

Updated reservation documentation.

Clarified differences between the RESERVE offer operation and the `/reserve` 
operator endpoint.


Diffs
-

  docs/reservation.md 25337109ff19240f926667961a59323bbfeb9956 

Diff: https://reviews.apache.org/r/43201/diff/


Testing
---

Viewed in the mesos website container: 
https://github.com/mesosphere/mesos-website-container


Thanks,

Greg Mann