Re: Review Request 43292: Fixed cleanup logic in `cgroups/net_cls` isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43292/#review118257 --- Ship it! Ship It! - Jie Yu On Feb. 7, 2016, 1:09 a.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43292/ > --- > > (Updated Feb. 7, 2016, 1:09 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4345 > https://issues.apache.org/jira/browse/MESOS-4345 > > > Repository: mesos > > > Description > --- > > We should be responsible for freeing a handle only if the handle > manager is set. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > fd674090d4b7f22b98571b693d71493d71b8e05e > > Diff: https://reviews.apache.org/r/43292/diff/ > > > Testing > --- > > make and make check. > > > Thanks, > > Avinash sridharan > >
Review Request 43292: Fixed cleanup logic in `cgroups/net_cls` isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43292/ --- Review request for mesos and Jie Yu. Bugs: MESOS-4345 https://issues.apache.org/jira/browse/MESOS-4345 Repository: mesos Description --- We should be responsible for freeing a handle only if the handle manager is set. Diffs - src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp fd674090d4b7f22b98571b693d71493d71b8e05e Diff: https://reviews.apache.org/r/43292/diff/ Testing --- make and make check. Thanks, Avinash sridharan
Re: Review Request 43292: Fixed cleanup logic in `cgroups/net_cls` isolator.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43292/#review118171 --- Patch looks great! Reviews applied: [43292] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Feb. 7, 2016, 1:09 a.m., Avinash sridharan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43292/ > --- > > (Updated Feb. 7, 2016, 1:09 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-4345 > https://issues.apache.org/jira/browse/MESOS-4345 > > > Repository: mesos > > > Description > --- > > We should be responsible for freeing a handle only if the handle > manager is set. > > > Diffs > - > > src/slave/containerizer/mesos/isolators/cgroups/net_cls.cpp > fd674090d4b7f22b98571b693d71493d71b8e05e > > Diff: https://reviews.apache.org/r/43292/diff/ > > > Testing > --- > > make and make check. > > > Thanks, > > Avinash sridharan > >
