Re: Review Request 43303: Libprocess: Added 'parent_hooks' as an argument to 'subprocess'.

2016-02-10 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43303/
---

(Updated Feb. 10, 2016, 4:49 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Bugs: MESOS-4636
https://issues.apache.org/jira/browse/MESOS-4636


Repository: mesos


Description
---

In the future we will remove the default argument for `parent_hooks` to
force the caller to think about what kind of subprocess they want
to launch.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
bb50cc3070245a294fa16efe44f14ae893bc5518 
  3rdparty/libprocess/src/subprocess.cpp 
ff477e37a9619c780bddd5a8e629fa981b729715 

Diff: https://reviews.apache.org/r/43303/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 43303: Libprocess: Added 'parent_hooks' as an argument to 'subprocess'.

2016-02-09 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43303/
---

(Updated Feb. 9, 2016, 7:13 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Summary (updated)
-

Libprocess: Added 'parent_hooks' as an argument to 'subprocess'.


Repository: mesos


Description (updated)
---

In the future we will remove the default argument for `parent_hooks` to
force the caller to think about what kind of subprocess they want
to launch.


Diffs (updated)
-

  3rdparty/libprocess/include/process/subprocess.hpp 
bb50cc3070245a294fa16efe44f14ae893bc5518 
  3rdparty/libprocess/src/subprocess.cpp 
ff477e37a9619c780bddd5a8e629fa981b729715 

Diff: https://reviews.apache.org/r/43303/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 43303: Libprocess: Added 'parent_hooks' as an argument to 'subprocess'.

2016-02-09 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43303/#review118568
---


Fix it, then Ship it!





3rdparty/libprocess/src/subprocess.cpp (line 428)


Can you s/blocking_pipes/pipes/ to be inline with the naming scheme you 
used above?



3rdparty/libprocess/src/subprocess.cpp (line 508)


Indentation?


- Benjamin Hindman


On Feb. 9, 2016, 7:13 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43303/
> ---
> 
> (Updated Feb. 9, 2016, 7:13 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> In the future we will remove the default argument for `parent_hooks` to
> force the caller to think about what kind of subprocess they want
> to launch.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> bb50cc3070245a294fa16efe44f14ae893bc5518 
>   3rdparty/libprocess/src/subprocess.cpp 
> ff477e37a9619c780bddd5a8e629fa981b729715 
> 
> Diff: https://reviews.apache.org/r/43303/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>