Re: Review Request 43307: Added systemd life-extension option to docker process containerizer.

2016-02-10 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43307/
---

(Updated Feb. 10, 2016, 4:52 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Bugs: MESOS-4637
https://issues.apache.org/jira/browse/MESOS-4637


Repository: mesos


Description
---

Added systemd life-extension option to docker process containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 19daf7d73cc8e0b0fd4afa58cc5ff7f6b7d9e345 

Diff: https://reviews.apache.org/r/43307/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 43307: Added systemd life-extension option to docker process containerizer.

2016-02-09 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43307/
---

(Updated Feb. 9, 2016, 7:14 p.m.)


Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description (updated)
---

Added systemd life-extension option to docker process containerizer.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 19daf7d73cc8e0b0fd4afa58cc5ff7f6b7d9e345 

Diff: https://reviews.apache.org/r/43307/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 43307: Added systemd life-extension option to docker process containerizer.

2016-02-09 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43307/#review118571
---


Fix it, then Ship it!





src/slave/containerizer/docker.cpp (line 963)


Can we use an `&` here as well please?


- Benjamin Hindman


On Feb. 9, 2016, 7:14 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43307/
> ---
> 
> (Updated Feb. 9, 2016, 7:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added systemd life-extension option to docker process containerizer.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 19daf7d73cc8e0b0fd4afa58cc5ff7f6b7d9e345 
> 
> Diff: https://reviews.apache.org/r/43307/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Review Request 43307: Added systemd life-extension option to docker process containerizer.

2016-02-07 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43307/
---

Review request for mesos, Benjamin Hindman and Jie Yu.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/slave/containerizer/docker.cpp 19daf7d73cc8e0b0fd4afa58cc5ff7f6b7d9e345 

Diff: https://reviews.apache.org/r/43307/diff/


Testing
---


Thanks,

Joris Van Remoortere