Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.

2016-02-16 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/
---

(Updated Feb. 16, 2016, 5:55 p.m.)


Review request for mesos, Alexander Rukletsov, Benjamin Bannier, and Bernd 
Mathiske.


Changes
---

Rebase


Bugs: MESOS-4618
https://issues.apache.org/jira/browse/MESOS-4618


Repository: mesos


Description
---

Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43316/diff/


Testing (updated)
---

Before
```
[   OK ] FetcherCacheTest.SimpleEviction (4536 ms)
```

After
```
[   OK ] FetcherCacheTest.SimpleEviction (3635 ms)
```


Thanks,

haosdent huang



Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.

2016-02-16 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/#review119301
---


Ship it!




Ship It!

- Benjamin Bannier


On Feb. 16, 2016, 12:39 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43316/
> ---
> 
> (Updated Feb. 16, 2016, 12:39 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/43316/diff/
> 
> 
> Testing
> ---
> 
> Before
> 
> ```
> [   OK ] FetcherCacheTest.SimpleEviction (4516 ms)
> [--] 1 test from FetcherCacheTest (4516 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (4527 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> After
> 
> ```
> [   OK ] FetcherCacheTest.SimpleEviction (3602 ms)
> [--] 1 test from FetcherCacheTest (3602 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (3612 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.

2016-02-16 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/
---

(Updated Feb. 16, 2016, 11:39 a.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Rebase


Summary (updated)
-

Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.


Bugs: MESOS-4618
https://issues.apache.org/jira/browse/MESOS-4618


Repository: mesos


Description (updated)
---

Decrease countCacheEntries in FetcherCacheTest.SimpleEviction.


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43316/diff/


Testing
---

Before

```
[   OK ] FetcherCacheTest.SimpleEviction (4516 ms)
[--] 1 test from FetcherCacheTest (4516 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (4527 ms total)
[  PASSED  ] 1 test.
```

After

```
[   OK ] FetcherCacheTest.SimpleEviction (3602 ms)
[--] 1 test from FetcherCacheTest (3602 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (3612 ms total)
[  PASSED  ] 1 test.
```


Thanks,

haosdent huang



Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .

2016-02-09 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/
---

(Updated Feb. 9, 2016, 6:18 p.m.)


Review request for mesos and Bernd Mathiske.


Changes
---

Rebase.


Bugs: MESOS-4618
https://issues.apache.org/jira/browse/MESOS-4618


Repository: mesos


Description
---

Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .


Diffs (updated)
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43316/diff/


Testing
---

Before

```
[   OK ] FetcherCacheTest.SimpleEviction (4516 ms)
[--] 1 test from FetcherCacheTest (4516 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (4527 ms total)
[  PASSED  ] 1 test.
```

After

```
[   OK ] FetcherCacheTest.SimpleEviction (3602 ms)
[--] 1 test from FetcherCacheTest (3602 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (3612 ms total)
[  PASSED  ] 1 test.
```


Thanks,

haosdent huang



Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .

2016-02-08 Thread Bernd Mathiske

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/#review118227
---


Ship it!




Ship It!

- Bernd Mathiske


On Feb. 7, 2016, 10:38 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43316/
> ---
> 
> (Updated Feb. 7, 2016, 10:38 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/43316/diff/
> 
> 
> Testing
> ---
> 
> Before
> 
> ```
> [   OK ] FetcherCacheTest.SimpleEviction (4516 ms)
> [--] 1 test from FetcherCacheTest (4516 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (4527 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> After
> 
> ```
> [   OK ] FetcherCacheTest.SimpleEviction (3602 ms)
> [--] 1 test from FetcherCacheTest (3602 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (3612 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .

2016-02-07 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/#review118184
---



Patch looks great!

Reviews applied: [42696, 43316]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 7, 2016, 6:38 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43316/
> ---
> 
> (Updated Feb. 7, 2016, 6:38 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4618
> https://issues.apache.org/jira/browse/MESOS-4618
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .
> 
> 
> Diffs
> -
> 
>   src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 
> 
> Diff: https://reviews.apache.org/r/43316/diff/
> 
> 
> Testing
> ---
> 
> Before
> 
> ```
> [   OK ] FetcherCacheTest.SimpleEviction (4516 ms)
> [--] 1 test from FetcherCacheTest (4516 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (4527 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> After
> 
> ```
> [   OK ] FetcherCacheTest.SimpleEviction (3602 ms)
> [--] 1 test from FetcherCacheTest (3602 ms total)
> 
> [--] Global test environment tear-down
> [==] 1 test from 1 test case ran. (3612 ms total)
> [  PASSED  ] 1 test.
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .

2016-02-07 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/
---

Review request for mesos.


Repository: mesos


Description
---

Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .


Diffs
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43316/diff/


Testing
---

Before

```
[   OK ] FetcherCacheTest.SimpleEviction (4516 ms)
[--] 1 test from FetcherCacheTest (4516 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (4527 ms total)
[  PASSED  ] 1 test.
```

After

```
[   OK ] FetcherCacheTest.SimpleEviction (3602 ms)
[--] 1 test from FetcherCacheTest (3602 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (3612 ms total)
[  PASSED  ] 1 test.
```


Thanks,

haosdent huang



Re: Review Request 43316: Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .

2016-02-07 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43316/
---

(Updated Feb. 7, 2016, 6:38 p.m.)


Review request for mesos and Bernd Mathiske.


Bugs: MESOS-4618
https://issues.apache.org/jira/browse/MESOS-4618


Repository: mesos


Description
---

Decrease countCacheEntries in FetcherCacheTest.SimpleEviction .


Diffs
-

  src/tests/fetcher_cache_tests.cpp 1cf45660691860793ac600363f7934e13a2e7ddf 

Diff: https://reviews.apache.org/r/43316/diff/


Testing
---

Before

```
[   OK ] FetcherCacheTest.SimpleEviction (4516 ms)
[--] 1 test from FetcherCacheTest (4516 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (4527 ms total)
[  PASSED  ] 1 test.
```

After

```
[   OK ] FetcherCacheTest.SimpleEviction (3602 ms)
[--] 1 test from FetcherCacheTest (3602 ms total)

[--] Global test environment tear-down
[==] 1 test from 1 test case ran. (3612 ms total)
[  PASSED  ] 1 test.
```


Thanks,

haosdent huang