Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 22, 2016, 3:48 p.m.) Review request for mesos, Alexander

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review120143 --- Fix it, then Ship it! src/tests/fetcher_cache_tests.cpp (line

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

> On Feb. 19, 2016, 1:02 a.m., Alexander Rukletsov wrote: > > src/tests/fetcher_cache_tests.cpp, lines 189-191 > > > > > > Will it be more clear to explicitly advance clock in those tests? I > > think keeping

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

> On Feb. 19, 2016, 9:02 a.m., Alexander Rukletsov wrote: > > src/tests/fetcher_cache_tests.cpp, lines 189-191 > > > > > > Will it be more clear to explicitly advance clock in those tests? I > > think keeping

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119635 --- Patch looks great! Reviews applied: [43608, 42696, 43367]

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 18, 2016, 2:54 p.m.) Review request for mesos, Alexander

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 18, 2016, 2:52 p.m.) Review request for mesos, Alexander

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119615 --- Fix it, then Ship it! src/tests/fetcher_cache_tests.cpp (line

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119490 --- Patch looks great! Reviews applied: [43608, 42696, 43367]

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 17, 2016, 4:55 p.m.) Review request for mesos, Alexander

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

> On Feb. 17, 2016, 10:09 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 197 > > > > > > Having run multiple test suite runs, I am not convinced this has much > > of an effect. I got

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

> On Feb. 17, 2016, 2:09 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 197 > > > > > > Having run multiple test suite runs, I am not convinced this has much > > of an effect. I got results

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119436 --- src/tests/fetcher_cache_tests.cpp (lines 194 - 196)

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

> On Feb. 17, 2016, 10:09 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 197 > > > > > > Having run multiple test suite runs, I am not convinced this has much > > of an effect. I got

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119434 --- src/tests/fetcher_cache_tests.cpp (line 197)

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

> On Feb. 17, 2016, 5:10 a.m., Guangya Liu wrote: > > src/tests/fetcher_cache_tests.cpp, line 194 > > > > > > Can you please summary the discussion of you and bernd-mesos for why > > not using `Clock::settle()` so

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 17, 2016, 9:54 a.m.) Review request for mesos, Alexander

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119425 --- Patch looks great! Reviews applied: [43608, 42696, 43367]

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119413 --- src/tests/fetcher_cache_tests.cpp (line 194)

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 17, 2016, 2:11 a.m.) Review request for mesos, Alexander

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 16, 2016, 6:03 p.m.) Review request for mesos, Alexander

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 16, 2016, 5:58 p.m.) Review request for mesos and Bernd

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/#review119303 --- Patch looks great! Reviews applied: [42696, 43316, 43367]

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

> On Feb. 16, 2016, 3:02 a.m., Bernd Mathiske wrote: > > src/tests/fetcher_cache_tests.cpp, line 422 > > > > > > In some fetcher cache tests, we specifically want to find out if > > concurrent execution of

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 16, 2016, 11:42 a.m.) Review request for mesos and Bernd

Re: Review Request 43367: Speed up FetcherCache test cases by reduce allocation_interval.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43367/ --- (Updated Feb. 16, 2016, 11:41 a.m.) Review request for mesos and Bernd