Re: Review Request 43451: Fixed local puller switch condition to support docker registry.

2016-02-10 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43451/
---

(Updated Feb. 10, 2016, 4:42 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Fixed local puller switch condition to support docker registry.


Diffs (updated)
-

  docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
6ae920a820a7604c97debf9fd21de24dda8e4d36 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
5650f2f51c0ea31527c6c51eb498d87ddf2a4fec 
  src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 
  src/tests/containerizer/provisioner_docker_tests.cpp 
824f8978e02e9af803ef16aeb2fd6bf6d162dbd1 

Diff: https://reviews.apache.org/r/43451/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song

Re: Review Request 43451: Fixed local puller switch condition to support docker registry.

2016-02-10 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43451/#review118764
---


Fix it, then Ship it!





src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp (line 83)


No need for this temp variable anymore.


- Jie Yu


On Feb. 10, 2016, 11:44 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43451/
> ---
> 
> (Updated Feb. 10, 2016, 11:44 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed local puller switch condition to support docker registry.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> 6ae920a820a7604c97debf9fd21de24dda8e4d36 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> 5650f2f51c0ea31527c6c51eb498d87ddf2a4fec 
>   src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> 824f8978e02e9af803ef16aeb2fd6bf6d162dbd1 
> 
> Diff: https://reviews.apache.org/r/43451/diff/
> 
> 
> Testing
> ---
> 
> make check (ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Review Request 43451: Fixed local puller switch condition to support docker registry.

2016-02-10 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43451/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

Fixed local puller switch condition to support docker registry.


Diffs
-

  docs/configuration.md 4b5a394685b597704fe0f6bc038496295e19f6e1 
  src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
6ae920a820a7604c97debf9fd21de24dda8e4d36 
  src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
5650f2f51c0ea31527c6c51eb498d87ddf2a4fec 
  src/slave/flags.cpp 24a23325cc255d0d7b7af7ed096b6d3012ad75c7 
  src/tests/containerizer/provisioner_docker_tests.cpp 
824f8978e02e9af803ef16aeb2fd6bf6d162dbd1 

Diff: https://reviews.apache.org/r/43451/diff/


Testing
---

make check (ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song