Re: Review Request 43664: Modified SchedulerTest.Subscribe to not test for failover.

2016-02-26 Thread Anand Mazumdar
> On Feb. 27, 2016, 2:08 a.m., Vinod Kone wrote: > > src/tests/scheduler_tests.cpp, line 136 > > > > > > why will there be future invocations? > > Vinod Kone wrote: > I see the reasoning in the next review. Mayb

Re: Review Request 43664: Modified SchedulerTest.Subscribe to not test for failover.

2016-02-26 Thread Vinod Kone
> On Feb. 27, 2016, 2:08 a.m., Vinod Kone wrote: > > src/tests/scheduler_tests.cpp, line 136 > > > > > > why will there be future invocations? I see the reasoning in the next review. Maybe move this particular chang

Re: Review Request 43664: Modified SchedulerTest.Subscribe to not test for failover.

2016-02-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43664/#review121048 --- Fix it, then Ship it! src/tests/scheduler_tests.cpp (line 136)

Re: Review Request 43664: Modified SchedulerTest.Subscribe to not test for failover.

2016-02-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43664/ --- (Updated Feb. 17, 2016, 10:45 p.m.) Review request for mesos and Vinod Kone.

Review Request 43664: Modified SchedulerTest.Subscribe to not test for failover.

2016-02-17 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43664/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-3570 https://issues.ap