Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-23 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/#review120387 --- Ship it! Ship It! - Gilbert Song On Feb. 23, 2016, 12:11 p.m

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/ --- (Updated Feb. 23, 2016, 8:11 p.m.) Review request for mesos, Gilbert Song and T

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-23 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/ --- (Updated Feb. 23, 2016, 8:10 p.m.) Review request for mesos, Gilbert Song and T

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-23 Thread Jie Yu
> On Feb. 23, 2016, 7:26 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/docker/paths.hpp, line 35 > > > > > > Why removing this? I think that this still exist as a temp directory > > when pull

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-23 Thread Jie Yu
> On Feb. 23, 2016, 7:26 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/provisioner/docker/paths.hpp, lines 38-40 > > > > > > Do we need to add layer.tar here? That's a impl. detail. We would likely to re

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/#review120271 --- src/slave/containerizer/mesos/provisioner/docker/paths.hpp (line

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/#review120208 --- Ship it! Ship It! - Gilbert Song On Feb. 19, 2016, 10:09 p.m

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-22 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/#review120156 --- src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/#review120032 --- Patch looks great! Reviews applied: [43801] Passed command: expo

Re: Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/ --- (Updated Feb. 20, 2016, 6:09 a.m.) Review request for mesos, Gilbert Song and T

Review Request 43801: Refactored and simplified the docker puller interfaces.

2016-02-19 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43801/ --- Review request for mesos, Gilbert Song and Timothy Chen. Bugs: MESOS-4499 h